[GitHub] spark pull request #17150: [SPARK-19810][BUILD][CORE] Remove support for Sca...

[srowen <gi...@git.apache.org>]

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17150#discussion_r126964753
  
    --- Diff: core/src/main/scala/org/apache/spark/rpc/RpcTimeout.scala ---
    @@ -125,9 +125,9 @@ private[spark] object RpcTimeout {
         var foundProp: Option[(String, String)] = None
         while (itr.hasNext && foundProp.isEmpty) {
           val propKey = itr.next()
    -      conf.getOption(propKey).foreach { prop => foundProp = Some(propKey, prop) }
    +      conf.getOption(propKey).foreach { prop => foundProp = Some((propKey, prop)) }
    --- End diff --
    
    Lots of the changes are of this form. Whereas scalac will still accept two args to a method that accepts one Tuple2 arg, it's a warning in Scala 2.11 in some cases. I actually also enabled all warnings of this form.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org