[jira] [Commented] (HBASE-13943) Get rid of KeyValue#heapSizeWithoutTags

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-13943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608377#comment-14608377 ] 

Hadoop QA commented on HBASE-13943:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12742813/HBASE-13943.patch
  against master branch at commit f8bd578b80b4e656d799c82ca1b6191e35bb0ae4.
  ATTACHMENT ID: 12742813

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:red}-1 site{color}.  The patch appears to cause mvn post-site goal to fail.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.util.TestProcessBasedCluster
                  org.apache.hadoop.hbase.mapreduce.TestImportExport
                  org.apache.hadoop.hbase.TestRegionRebalancing

     {color:red}-1 core zombie tests{color}.  There are 5 zombie test(s): 	at org.apache.hadoop.hbase.namespace.TestNamespaceAuditor.testCloneSnapshot(TestNamespaceAuditor.java:715)
	at org.apache.hadoop.hbase.master.TestRestartCluster.testClusterRestart(TestRestartCluster.java:102)
	at org.apache.hadoop.hbase.master.TestRollingRestart.testBasicRollingRestart(TestRollingRestart.java:74)
	at org.apache.hadoop.hbase.namespace.TestNamespaceAuditor.testCloneSnapshot(TestNamespaceAuditor.java:715)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14618//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14618//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14618//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14618//console

This message is automatically generated.

> Get rid of KeyValue#heapSizeWithoutTags
> ---------------------------------------
>
>                 Key: HBASE-13943
>                 URL: https://issues.apache.org/jira/browse/HBASE-13943
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13943.patch
>
>
> {code}
> /**
>    * This is a hack that should be removed once we don't care about matching
>    * up client- and server-side estimations of cell size. It needed to be
>    * backwards compatible with estimations done by older clients. We need to
>    * pretend that tags never exist and cells aren't serialized with tag
>    * length included. See HBASE-13262 and HBASE-13303
>    */
>   @Deprecated
>   public static long estimatedHeapSizeOfWithoutTags(final Cell cell) {
>  {code}
>  We can avoid this for 2.0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)