You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/06/10 21:08:34 UTC
Review Request 35309: Added Resources::get() and Resources::names().
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35309/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Jie Yu.
Bugs: MESOS-2753
https://issues.apache.org/jira/browse/MESOS-2753
Repository: mesos
Description
-------
Need this for the subsequent review.
Diffs
-----
include/mesos/resources.hpp 6feb1be5a1463ae1a2d932b2ff696f79c7d9afb5
src/common/resources.cpp 01c79fbbf16bcbdc7a25953c49107863fce3e87f
src/tests/resources_tests.cpp 4952e1b5409103087ab7d7ad91bf907515d3c567
Diff: https://reviews.apache.org/r/35309/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 35309: Added Resources::get() and
Resources::names().
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35309/#review87460
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On June 10, 2015, 7:08 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35309/
> -----------------------------------------------------------
>
> (Updated June 10, 2015, 7:08 p.m.)
>
>
> Review request for mesos, Ben Mahler and Jie Yu.
>
>
> Bugs: MESOS-2753
> https://issues.apache.org/jira/browse/MESOS-2753
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Need this for the subsequent review.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 6feb1be5a1463ae1a2d932b2ff696f79c7d9afb5
> src/common/resources.cpp 01c79fbbf16bcbdc7a25953c49107863fce3e87f
> src/tests/resources_tests.cpp 4952e1b5409103087ab7d7ad91bf907515d3c567
>
> Diff: https://reviews.apache.org/r/35309/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 35309: Added Resources::get() and
Resources::names().
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35309/#review87489
-----------------------------------------------------------
Ship it!
I can use the code in this review if we get it committed soon.
- Jiang Yan Xu
On June 10, 2015, 12:08 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35309/
> -----------------------------------------------------------
>
> (Updated June 10, 2015, 12:08 p.m.)
>
>
> Review request for mesos, Ben Mahler and Jie Yu.
>
>
> Bugs: MESOS-2753
> https://issues.apache.org/jira/browse/MESOS-2753
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Need this for the subsequent review.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 6feb1be5a1463ae1a2d932b2ff696f79c7d9afb5
> src/common/resources.cpp 01c79fbbf16bcbdc7a25953c49107863fce3e87f
> src/tests/resources_tests.cpp 4952e1b5409103087ab7d7ad91bf907515d3c567
>
> Diff: https://reviews.apache.org/r/35309/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>