[GitHub] [dubbo] horizonzy commented on a change in pull request #8207: Fix the NPE (#8195)

[GitBox <gi...@apache.org>]

horizonzy commented on a change in pull request #8207:
URL: https://github.com/apache/dubbo/pull/8207#discussion_r663338152



##########
File path: dubbo-container/dubbo-container-api/src/main/java/org/apache/dubbo/container/Main.java
##########
@@ -60,7 +60,10 @@ public static void main(String[] args) {
 
             final List<Container> containers = new ArrayList<Container>();
             for (int i = 0; i < args.length; i++) {
-                containers.add(LOADER.getExtension(args[i]));
+                Container container = LOADER.getExtension(args[i]);

Review comment:
       here maybe throw exception will be better, tell user the args maybe wrong.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org