Re: Review Request 12063: Fix for CLOUDSTACK-2835: Registering router template and usage of router.template.* configuration parameter

[Abhinandan Prateek <ap...@apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12063/#review22393
-----------------------------------------------------------

Ship it!


Ship It!

- Abhinandan Prateek


On June 24, 2013, 3:39 p.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12063/
> -----------------------------------------------------------
> 
> (Updated June 24, 2013, 3:39 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-2835
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-2835:  VR Deployement from admin registered template is failing because registered template type is user. 
> Additional parameter "isrouter" in register/update template API for the root admin. True if registered template is of type ROUTING.
> 
> A new template type is introduced named "ROUTING" which is used to deploy router. 
> Admin registers a ROUTING type template and provides the value zone/global level configuration parameters in routing.template.xenserver/kvm/hyperv/vmware/lxc So that router deploys using that template.
> By default router can be deployed by the normal SYSTEM template.
> 
> Added upgrade case to update the configuration parameter values routing.template.xenserver/kvm/hyperv/vmware/lxc
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/storage/Storage.java 16ef019 
>   api/src/org/apache/cloudstack/api/ApiConstants.java 8ac7c3f 
>   api/src/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java b01c8d0 
>   api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java 6a8e555 
>   api/src/org/apache/cloudstack/api/command/user/template/UpdateTemplateCmd.java 9f55f9d 
>   engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java e7b85f8 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 8f63a6c 
>   server/src/com/cloud/server/ManagementServerImpl.java 97bac1b 
>   server/src/com/cloud/storage/TemplateProfile.java 00aab4d 
>   server/src/com/cloud/template/TemplateAdapter.java d50d45b 
>   server/src/com/cloud/template/TemplateAdapterBase.java c1f0604 
>   server/src/com/cloud/template/TemplateManagerImpl.java 273614c 
> 
> Diff: https://reviews.apache.org/r/12063/diff/
> 
> 
> Testing
> -------
> 
> Tested locally.
> 
> Registered ROUTING template and checked router deployment by setting the configuration parameter routing.template.xenserver to the new ROUTING template.
> Tested the default behavior of router deployment from SYSTEM template.
> 
> Tested upgrade case from 4.1 to 4.2  
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>