You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "FlyingZC (via GitHub)" <gi...@apache.org> on 2026/08/12 02:54:50 UTC
[PR] Support unquoted Han text from Oracle DUAL [shardingsphere]
FlyingZC opened a new pull request, #39415:
URL: https://github.com/apache/shardingsphere/pull/39415
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support unquoted Han text from Oracle DUAL [shardingsphere]
Posted by "iamhucong (via GitHub)" <gi...@apache.org>.
iamhucong merged PR #39415:
URL: https://github.com/apache/shardingsphere/pull/39415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support unquoted Han text from Oracle DUAL [shardingsphere]
Posted by "FlyingZC (via GitHub)" <gi...@apache.org>.
FlyingZC commented on PR #39415:
URL: https://github.com/apache/shardingsphere/pull/39415#issuecomment-5261736312
### Summary
**Review Result: Mergeable**
**Reason:** The change fixes the Oracle parser and binder handling of unquoted Han text selected from `DUAL`. This result covers code correctness only; CI not reviewed by request.
### Evidence
- The new grammar branch is restricted to a query block beginning with Han text, optionally separated by Chinese full-width commas, followed by `AS <alias> FROM DUAL`.
- The visitor represents the complete Han text as one `LiteralExpressionSegment` inside an expression projection, preventing the binder from resolving the text as unknown columns.
- The change introduces no SQL rewrite logic, so the original SQL remains available for backend execution and SQL Translation Profile processing.
- Regression cases verify that `DUMMY`, quoted Chinese identifiers, ASCII-comma column lists, and equivalent projections from a non-`DUAL` table continue through the existing column-projection path.
- A separate Oracle 12.2 runtime check confirmed that the original SQL can reach the backend unchanged when an SQL Translation Profile is configured.
- Oracle parser IT: 1,818 tests passed.
- Oracle binder IT: 9 tests passed.
- Spotless and Checkstyle passed.
### Review Details
- **Review Focus:** Code Correctness Review — CI not reviewed by request.
- **Reviewed Scope:** All 7 changed Oracle grammar, visitor, parser-test, and binder-test files at `8f170c868f01c68a378cf621adaf3da394c0801d`; merge base `881898ca445598de81bfc711d32acd7c7957e5ad`. The local file list matches the GitHub PR file list.
- **Dialect Scope:** Oracle only. No shared grammar or other SQL dialect implementation is changed.
- **Not Reviewed Scope:** GitHub Actions, unrelated dialects, and features outside this Oracle parser and binder path.
- **Verification:** Spotless and Checkstyle completed successfully. `InternalOracleParserIT` passed 1,818 tests and `OracleBinderIT` passed 9 tests.
- **Release Note / User Docs:** Not required because this is a narrowly scoped parser compatibility fix with no configuration, API, SPI, or migration change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org