[GitHub] [kafka] mjsax commented on a diff in pull request #13022: MINOR: fix expected version in streams upgrade test

[GitBox <gi...@apache.org>]

mjsax commented on code in PR #13022:
URL: https://github.com/apache/kafka/pull/13022#discussion_r1052583424


##########
tests/kafkatest/tests/streams/streams_upgrade_test.py:
##########
@@ -506,7 +508,7 @@ def do_rolling_bounce(self, processor, counter, current_generation):
                     self.upgraded_processors.append(processor)
 
                     # checking for the dev version which should be the only SNAPSHOT
-                    log_monitor.wait_until("Kafka version.*" + self.base_version_number + ".*SNAPSHOT",
+                    log_monitor.wait_until(kafka_version_str,

Review Comment:
   I am not 100% sure, but I assume something upstream changed and a new version is passed in.
   
   Guess it depends what artifact are used to run the test -- if we build from release branches, the `SNAPSHOT` suffix should be contained, but if we run the test with release artifacts, the `SNAPSHOT` might have been removed already.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org