You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/07/30 20:14:52 UTC
[GitHub] [pulsar] jerrypeng commented on a change in pull request #4846: Fix
pulsar admin functions description information
jerrypeng commented on a change in pull request #4846: Fix pulsar admin functions description information
URL: https://github.com/apache/pulsar/pull/4846#discussion_r308921754
##########
File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
##########
@@ -107,10 +107,10 @@ void processArguments() throws Exception {}
*/
@Getter
abstract class NamespaceCommand extends BaseCommand {
- @Parameter(names = "--tenant", description = "The function's tenant")
+ @Parameter(names = "--tenant", description = "The tenant of functions")
Review comment:
Why are we changing to this wording? This config is the tenant of a particular Pulsar Function the user is trying to submit. Its not the tenant of Pulsar Functions framework. Changing the wording to this seems confusing to me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services