You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/09/25 14:21:06 UTC
[GitHub] [james-project] ouvtam opened a new pull request, #1207: JAMES-3820 implement DNSRBLHandler as a MailHook instead of RcptHook …
ouvtam opened a new pull request, #1207:
URL: https://github.com/apache/james-project/pull/1207
…to call it as soon as possible after SMTP authentication.
At the moment the DNSRBL handler is implemented as a RcptHook. Thus, for every RCPT TO call this handler will be called and a blocklist lookup will be issued.
One can argue It makes sense to implement the handler as a ConnectHandler, so the blocklist check is done as early as possible. However, if SMTP AUTH is successful then we should allow the connecting client anyway.
Therefore it makes sense to implement the DNSRBL handler at MAIL FROM stage that is MailHook. One caveat: According to [RFC 4954](https://datatracker.ietf.org/doc/html/rfc4954#section-5), authentication information can optionally provided as ESMTP AUTH parameter with a single value in the 'MAIL FROM:' command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] ouvtam commented on pull request #1207: JAMES-3820 implement DNSRBLHandler as a MailHook instead of RcptHook …
Posted by GitBox <gi...@apache.org>.
ouvtam commented on PR #1207:
URL: https://github.com/apache/james-project/pull/1207#issuecomment-1257246991
As discussed in https://issues.apache.org/jira/browse/JAMES-3820 I cleaned up additional RcptHooks that should rather be MailHooks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #1207: JAMES-3820 implement DNSRBLHandler as a MailHook instead of RcptHook …
Posted by GitBox <gi...@apache.org>.
chibenwa commented on PR #1207:
URL: https://github.com/apache/james-project/pull/1207#issuecomment-1257565390
```
06:21:05,972 [ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project custom-smtp-command: Compilation failure
```
More compile errors :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #1207: JAMES-3820 implement DNSRBLHandler as a MailHook instead of RcptHook …
Posted by GitBox <gi...@apache.org>.
chibenwa merged PR #1207:
URL: https://github.com/apache/james-project/pull/1207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] ouvtam commented on pull request #1207: JAMES-3820 implement DNSRBLHandler as a MailHook instead of RcptHook …
Posted by GitBox <gi...@apache.org>.
ouvtam commented on PR #1207:
URL: https://github.com/apache/james-project/pull/1207#issuecomment-1260479761
Some tests are failing but they are not caused by my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] ouvtam commented on pull request #1207: JAMES-3820 implement DNSRBLHandler as a MailHook instead of RcptHook …
Posted by GitBox <gi...@apache.org>.
ouvtam commented on PR #1207:
URL: https://github.com/apache/james-project/pull/1207#issuecomment-1258383698
Some tests are still failing. I am going to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #1207: JAMES-3820 implement DNSRBLHandler as a MailHook instead of RcptHook …
Posted by GitBox <gi...@apache.org>.
chibenwa commented on PR #1207:
URL: https://github.com/apache/james-project/pull/1207#issuecomment-1259159900
> So this PR needs some rework.
I turn the PR into a draft to make this clear.
Once necessary fixes are in place, we can un-draft this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #1207: JAMES-3820 implement DNSRBLHandler as a MailHook instead of RcptHook …
Posted by GitBox <gi...@apache.org>.
chibenwa commented on PR #1207:
URL: https://github.com/apache/james-project/pull/1207#issuecomment-1260282207
`SmtpIdentityVerificationTest` are failing...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] ouvtam commented on pull request #1207: JAMES-3820 implement DNSRBLHandler as a MailHook instead of RcptHook …
Posted by GitBox <gi...@apache.org>.
ouvtam commented on PR #1207:
URL: https://github.com/apache/james-project/pull/1207#issuecomment-1259117601
I need to reintroduce the RcptHooks (see discussion in https://issues.apache.org/jira/browse/JAMES-3820) because of different behaviour when running James as MSA (mail submission agent) or MTA (mail transfer agent).
So this PR needs some rework.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] ouvtam commented on pull request #1207: JAMES-3820 implement DNSRBLHandler as a MailHook instead of RcptHook …
Posted by GitBox <gi...@apache.org>.
ouvtam commented on PR #1207:
URL: https://github.com/apache/james-project/pull/1207#issuecomment-1257529132
sorry, I missed that one. I've updated the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #1207: JAMES-3820 implement DNSRBLHandler as a MailHook instead of RcptHook …
Posted by GitBox <gi...@apache.org>.
chibenwa commented on PR #1207:
URL: https://github.com/apache/james-project/pull/1207#issuecomment-1257371223
`Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check (check-style) on project james-server-protocols-smtp: You have 2 Checkstyle violations.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org