[jira] [Updated] (HADOOP-14130) Simplify DynamoDBClientFactory for creating Amazon DynamoDB clients

["Mingliang Liu (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-14130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mingliang Liu updated HADOOP-14130:
-----------------------------------
       Resolution: Fixed
     Hadoop Flags: Reviewed
    Fix Version/s: HADOOP-13345
           Status: Resolved  (was: Patch Available)

{quote}
If I understand correctly, the new API requires region as well, when you specify endpoint?
{quote}
That's correct. I don't know the major concern aws sdk team, but a hint is that:
{code}
    /**
     * ...
     *<p><b>Only use this if using a non-standard service endpoint - the recommended approach for configuring a client is to use {@link #withRegion(String)}</b>
     *
     * @param endpointConfiguration The endpointConfiguration to use
     * @return This object for method chaining.
     */
    public final Subclass withEndpointConfiguration(EndpointConfiguration endpointConfiguration) {
...
{code}

Thank you very much [~fabbri], [~mackrorysd] and [~stevel@apache.org] for your review. I'm happy we reach enough consensus here. I understand your concerns and adding back DDB point can happen anytime when we find it's useful (e.g. AWS sdk changes, new use cases we're not yet aware of).

Tested (v1) against us-west-1 region. I committed the patch to feature branch.

> Simplify DynamoDBClientFactory for creating Amazon DynamoDB clients
> -------------------------------------------------------------------
>
>                 Key: HADOOP-14130
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14130
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>            Reporter: Mingliang Liu
>            Assignee: Mingliang Liu
>             Fix For: HADOOP-13345
>
>         Attachments: HADOOP-14130-HADOOP-13345.000.patch, HADOOP-14130-HADOOP-13345.001.patch
>
>
> So, we are using deprecated {{AmazonDynamoDBClient}} class to create a DynamoDB client instead of the recommended builder. We had discussion in [HADOOP-14090] for preferring region to endpoints for user to specify the DynamoDB region (if associated S3 region is unknown or different). We have reported inconsistent behavior if endpoint and S3 region are different in [HADOOP-14027]. We also noticed that {{DynamoDBMetadataStore}} may sometimes logs nonsense region. And in [HADOOP-13252], we also have feelings that file system URI is not needed to create a {{AWSCredentialProvider}}. Resultantly we don't need to pass down file system URI for creating a DynamoDB client.
> So this JIRA is to change this, best effort.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org