[GitHub] [airflow] jaketf commented on a change in pull request #6386: [AIRFLOW-5716][part of AIRFLOW-5697] Simplify DataflowJobsController logic

[GitBox <gi...@apache.org>]

jaketf commented on a change in pull request #6386: [AIRFLOW-5716][part of AIRFLOW-5697] Simplify DataflowJobsController logic
URL: https://github.com/apache/airflow/pull/6386#discussion_r344465471
 
 

 ##########
 File path: airflow/gcp/hooks/dataflow.py
 ##########
 @@ -334,15 +357,16 @@ def _start_dataflow(
         name: str,
         command_prefix: List[str],
         label_formatter: Callable[[Dict], List[str]],
-        multiple_jobs: bool = False
+        project_id: str,
+        multiple_jobs: bool = False,
     ) -> None:
         variables = self._set_variables(variables)
-        cmd = command_prefix + self._build_cmd(variables, label_formatter)
+        cmd = command_prefix + self._build_cmd(variables, label_formatter, project_id)
         runner = _DataflowRunner(cmd)
         job_id = runner.wait_for_done()
 
 Review comment:
   My understanding that this client side controller process that supervises the job is only the case for "normal" jobs that would be submitted with `DataflowPythonOperator` or `DataflowJavaOperator`. However templates can be instantiated and poll for completion separately (see [running templates](https://cloud.google.com/dataflow/docs/guides/templates/running-templates)).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services