You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Santhosh Edukulla <sa...@citrix.com> on 2013/12/31 16:24:44 UTC

4.3 : Developer Profile, tools module commented

Team,

For branch 4,3, the below commit appears to have commented the tools module under developer profile. Any specific reason?

commit fb1f3f0865c254abebfa5a43f66cef116fe36165
Author: Frank.Zhang <fr...@citrix.com>
Date:   Mon Oct 7 18:03:12 2013 -0700

    Add missing Baremetal security_group_agent java part
    Change security_group_agent python side in line with default security
    group rules change in 4.2
    
    Conflicts:
    
        plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BareMetalResourceBase.java

diff --git a/pom.xml b/pom.xml
index 2cee084..31946d8 100644
--- a/pom.xml
+++ b/pom.xml
@@ -747,7 +747,9 @@
       </properties>
       <modules>
         <module>developer</module>
+        <!--
         <module>tools</module>
+-->
       </modules>
     </profile>
     <profile>

Thanks!
Santhosh

RE: 4.3 : Developer Profile, tools module commented

Posted by Frank Zhang <Fr...@citrix.com>.
Has gotten it back
f0ad14e23574041ee75eb4e34bdbab69f05c909b

thanks 

> -----Original Message-----
> From: Santhosh Edukulla [mailto:santhosh.edukulla@citrix.com]
> Sent: Monday, January 06, 2014 10:07 PM
> To: dev@cloudstack.apache.org
> Subject: RE: 4.3 : Developer Profile, tools module commented
> 
> 1. Not sure build it is taking much time because of tools module.  tools also
> builds apidoc which could be intentional( may be ) to include it as part of
> developer profile and has its subsequent references for marvin.
> 
> 2. We can bring it back for now under developer profile. Especially, we have RC
> lined up now and current usage could have references to usages\mention at
> that other places like docs\wiki\current of using the current way of building and
> using tools.Impatient seems to be little misnomer to use.
> 
> 3. There was a reference to speed up build time @
> http://markmail.org/message/3ch4lgaq4yjaop7e?q=darren+shepherd+mvn
> 
> Regards,
> Santhosh
> ________________________________________
> From: Frank Zhang [Frank.Zhang@citrix.com]
> Sent: Monday, January 06, 2014 6:17 PM
> To: dev@cloudstack.apache.org
> Subject: RE: 4.3 : Developer Profile, tools module commented
> 
> Sorry this was by a mistake.
> The maven build costs too long so I comment tools out as it's rarely used by
> developer build. later on I found there is a profile called 'impatient' which does
> exactly the same thing.
> before bring it back, I wonder if it's right to put 'tools' in developer profile? I
> am sure 90% developer won't use it. Why not move it to a profile only used by
> RPM build?
> 
> > -----Original Message-----
> > From: Santhosh Edukulla [mailto:santhosh.edukulla@citrix.com]
> > Sent: Tuesday, December 31, 2013 7:25 AM
> > To: dev@cloudstack.apache.org
> > Subject: 4.3 : Developer Profile, tools module commented
> >
> > Team,
> >
> > For branch 4,3, the below commit appears to have commented the tools
> > module under developer profile. Any specific reason?
> >
> > commit fb1f3f0865c254abebfa5a43f66cef116fe36165
> > Author: Frank.Zhang <fr...@citrix.com>
> > Date:   Mon Oct 7 18:03:12 2013 -0700
> >
> >     Add missing Baremetal security_group_agent java part
> >     Change security_group_agent python side in line with default security
> >     group rules change in 4.2
> >
> >     Conflicts:
> >
> >
> > plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/B
> > are
> > MetalResourceBase.java
> >
> > diff --git a/pom.xml b/pom.xml
> > index 2cee084..31946d8 100644
> > --- a/pom.xml
> > +++ b/pom.xml
> > @@ -747,7 +747,9 @@
> >        </properties>
> >        <modules>
> >          <module>developer</module>
> > +        <!--
> >          <module>tools</module>
> > +-->
> >        </modules>
> >      </profile>
> >      <profile>
> >
> > Thanks!
> > Santhosh

RE: 4.3 : Developer Profile, tools module commented

Posted by Santhosh Edukulla <sa...@citrix.com>.
1. Not sure build it is taking much time because of tools module.  tools also builds apidoc which could be intentional( may be ) to include it as part of developer profile and has its subsequent references for marvin. 

2. We can bring it back for now under developer profile. Especially, we have RC lined up now and current usage could have references to usages\mention at  that other places like docs\wiki\current of using the current way of building and using tools.Impatient seems to be little misnomer to use.

3. There was a reference to speed up build time @ http://markmail.org/message/3ch4lgaq4yjaop7e?q=darren+shepherd+mvn

Regards,
Santhosh
________________________________________
From: Frank Zhang [Frank.Zhang@citrix.com]
Sent: Monday, January 06, 2014 6:17 PM
To: dev@cloudstack.apache.org
Subject: RE: 4.3 : Developer Profile, tools module commented

Sorry this was by a mistake.
The maven build costs too long so I comment tools out as it's rarely used by developer build. later on I found there is
a profile called 'impatient' which does exactly the same thing.
before bring it back, I wonder if it's right to put 'tools' in developer profile? I am sure 90% developer won't use it. Why not
move it to a profile only used by RPM build?

> -----Original Message-----
> From: Santhosh Edukulla [mailto:santhosh.edukulla@citrix.com]
> Sent: Tuesday, December 31, 2013 7:25 AM
> To: dev@cloudstack.apache.org
> Subject: 4.3 : Developer Profile, tools module commented
>
> Team,
>
> For branch 4,3, the below commit appears to have commented the tools
> module under developer profile. Any specific reason?
>
> commit fb1f3f0865c254abebfa5a43f66cef116fe36165
> Author: Frank.Zhang <fr...@citrix.com>
> Date:   Mon Oct 7 18:03:12 2013 -0700
>
>     Add missing Baremetal security_group_agent java part
>     Change security_group_agent python side in line with default security
>     group rules change in 4.2
>
>     Conflicts:
>
>
> plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/Bare
> MetalResourceBase.java
>
> diff --git a/pom.xml b/pom.xml
> index 2cee084..31946d8 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -747,7 +747,9 @@
>        </properties>
>        <modules>
>          <module>developer</module>
> +        <!--
>          <module>tools</module>
> +-->
>        </modules>
>      </profile>
>      <profile>
>
> Thanks!
> Santhosh

RE: 4.3 : Developer Profile, tools module commented

Posted by Frank Zhang <Fr...@citrix.com>.
Sorry this was by a mistake.
The maven build costs too long so I comment tools out as it's rarely used by developer build. later on I found there is 
a profile called 'impatient' which does exactly the same thing.
before bring it back, I wonder if it's right to put 'tools' in developer profile? I am sure 90% developer won't use it. Why not
move it to a profile only used by RPM build?  

> -----Original Message-----
> From: Santhosh Edukulla [mailto:santhosh.edukulla@citrix.com]
> Sent: Tuesday, December 31, 2013 7:25 AM
> To: dev@cloudstack.apache.org
> Subject: 4.3 : Developer Profile, tools module commented
> 
> Team,
> 
> For branch 4,3, the below commit appears to have commented the tools
> module under developer profile. Any specific reason?
> 
> commit fb1f3f0865c254abebfa5a43f66cef116fe36165
> Author: Frank.Zhang <fr...@citrix.com>
> Date:   Mon Oct 7 18:03:12 2013 -0700
> 
>     Add missing Baremetal security_group_agent java part
>     Change security_group_agent python side in line with default security
>     group rules change in 4.2
> 
>     Conflicts:
> 
> 
> plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/Bare
> MetalResourceBase.java
> 
> diff --git a/pom.xml b/pom.xml
> index 2cee084..31946d8 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -747,7 +747,9 @@
>        </properties>
>        <modules>
>          <module>developer</module>
> +        <!--
>          <module>tools</module>
> +-->
>        </modules>
>      </profile>
>      <profile>
> 
> Thanks!
> Santhosh