You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@beam.apache.org by Tomo Suzuki <su...@google.com> on 2020/05/15 18:06:25 UTC

BEAM-9958: Code Review Wanted for PR 11674

Hi Luke and Beam committers,

Would you check this PR to use Linkage Checker's exclusion file?
https://github.com/apache/beam/pull/11674
This script used to use "diff" command to identify new linkage errors by
comparing line by line. With this PR, it identifies new linkage errors in
an appropriate manner. This PR opens up an opportunity to set up a Jenkins
job to check dependency conflicts.

-- 
Regards,
Tomo

Re: BEAM-9958: Code Review Wanted for PR 11674

Posted by Luke Cwik <lc...@google.com>.

Thanks Ahmet.

On Tue, May 19, 2020 at 1:26 PM Tomo Suzuki <su...@google.com> wrote:

> Ahmet,
>
> Thank you for the review and merging.
>
> On Fri, May 15, 2020 at 2:06 PM Tomo Suzuki <su...@google.com> wrote:
>
>> Hi Luke and Beam committers,
>>
>> Would you check this PR to use Linkage Checker's exclusion file?
>> https://github.com/apache/beam/pull/11674
>> This script used to use "diff" command to identify new linkage errors by
>> comparing line by line. With this PR, it identifies new linkage errors in
>> an appropriate manner. This PR opens up an opportunity to set up a Jenkins
>> job to check dependency conflicts.
>>
>> --
>> Regards,
>> Tomo
>>
>
>
> --
> Regards,
> Tomo
>

Re: BEAM-9958: Code Review Wanted for PR 11674

Posted by Tomo Suzuki <su...@google.com>.

Ahmet,

Thank you for the review and merging.

On Fri, May 15, 2020 at 2:06 PM Tomo Suzuki <su...@google.com> wrote:

> Hi Luke and Beam committers,
>
> Would you check this PR to use Linkage Checker's exclusion file?
> https://github.com/apache/beam/pull/11674
> This script used to use "diff" command to identify new linkage errors by
> comparing line by line. With this PR, it identifies new linkage errors in
> an appropriate manner. This PR opens up an opportunity to set up a Jenkins
> job to check dependency conflicts.
>
> --
> Regards,
> Tomo
>


-- 
Regards,
Tomo