You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/01 09:24:28 UTC
[GitHub] [beam] mosche opened a new pull request, #17793: Only generate Javadocs for latest Spark runner version (Spark 3) to f…
mosche opened a new pull request, #17793:
URL: https://github.com/apache/beam/pull/17793
The process of aggregating Javadocs is a bit sketchy in cases where source sets are shared. Particularly that’s the case for Spark and Flink runners.
Considering that everything is thrown into one bucket, we could easily end up with an inconsistent and misleading mix of Javadocs from multiple versions due to version specific overrides.
This disables Javadocs for the Spark2 runner so that `aggregateJavadoc` doesn't fail.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] y1chi commented on pull request #17793: Only generate Javadocs for latest Spark runner version (Spark 3)
Posted by GitBox <gi...@apache.org>.
y1chi commented on PR #17793:
URL: https://github.com/apache/beam/pull/17793#issuecomment-1143878177
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] y1chi merged pull request #17793: Only generate Javadocs for latest Spark runner version (Spark 3)
Posted by GitBox <gi...@apache.org>.
y1chi merged PR #17793:
URL: https://github.com/apache/beam/pull/17793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mosche commented on pull request #17793: Only generate Javadocs for latest Spark runner version (Spark 3)
Posted by GitBox <gi...@apache.org>.
mosche commented on PR #17793:
URL: https://github.com/apache/beam/pull/17793#issuecomment-1143360214
@y1chi sorry for breaking that... here's what I'd suggest to fix the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] y1chi commented on pull request #17793: Only generate Javadocs for latest Spark runner version (Spark 3)
Posted by GitBox <gi...@apache.org>.
y1chi commented on PR #17793:
URL: https://github.com/apache/beam/pull/17793#issuecomment-1143929661
Run Javadoc PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org