You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/03/28 04:54:52 UTC

[kudu-CR] [util] change return type of Cache::Allocate()

Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12876

to look at the new patch set (#2).

Change subject: [util] change return type of Cache::Allocate()
......................................................................

[util] change return type of Cache::Allocate()

This patch changes the signature of Cache::Allocate() and
Cache::Insert() methods to be explicit on the ownership of the memory
allocated behind Cache::PendingHandle.

Change-Id: I2b0fa72060456b167b61a816f8abb9cd4c8f56b6
---
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/block_cache.h
M src/kudu/codegen/code_cache.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/util/cache-bench.cc
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/cache.h
M src/kudu/util/file_cache.cc
M src/kudu/util/nvm_cache.cc
10 files changed, 96 insertions(+), 78 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/12876/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12876
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2b0fa72060456b167b61a816f8abb9cd4c8f56b6
Gerrit-Change-Number: 12876
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)