You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "AngersZhuuuu (via GitHub)" <gi...@apache.org> on 2024/01/02 08:27:17 UTC
[PR] [SPARK-46563][SQL] View simpleString not follow conf spark.sql.debug.maxToStringFields [spark]
AngersZhuuuu opened a new pull request, #44558:
URL: https://github.com/apache/spark/pull/44558
### What changes were proposed in this pull request?
View simpleString not follow conf spark.sql.debug.maxToStringFields
### Why are the changes needed?
When columns is too much, the info is noisy. View simpleString not follow conf spark.sql.debug.maxToStringFields
### Does this PR introduce _any_ user-facing change?
Yea, view's plan will follow ` spark.sql.debug.maxToStringFields`
### How was this patch tested?
No
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46563][SQL] View simpleString not follow conf spark.sql.debug.maxToStringFields [spark]
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #44558:
URL: https://github.com/apache/spark/pull/44558#issuecomment-1874894600
The remain failed GA seems not related?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46563][SQL] View simpleString not follow conf spark.sql.debug.maxToStringFields [spark]
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #44558:
URL: https://github.com/apache/spark/pull/44558#issuecomment-1873742365
> @AngersZhuuuu Could you check other places, please. I have found a couple more places where we could restrict the number of outputted fields:
>
> ```scala
> case class ExternalRDDScanExec[T](
> ...
> override def simpleString(maxFields: Int): String = {
> s"$nodeName${output.mkString("[", ",", "]")}"
> }
> ```
>
> and
>
> ```scala
> case class UnresolvedTableSpec(
> ...
> override def simpleString(maxFields: Int): String = {
> this.copy(properties = Utils.redact(properties).toMap).toString
> }
> ```
Yea, let me check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46563][SQL] View simpleString not follow conf spark.sql.debug.maxToStringFields [spark]
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #44558:
URL: https://github.com/apache/spark/pull/44558#issuecomment-1873774281
Checked all and done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46563][SQL] View simpleString not follow conf spark.sql.debug.maxToStringFields [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #44558:
URL: https://github.com/apache/spark/pull/44558#issuecomment-1875036362
> The remain failed GA seems not related?
Seems not.
+1, LGTM. Merging to master.
Thank you, @AngersZhuuuu and @yaooqinn @HyukjinKwon for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46563][SQL] View simpleString not follow conf spark.sql.debug.maxToStringFields [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #44558: [SPARK-46563][SQL] View simpleString not follow conf spark.sql.debug.maxToStringFields
URL: https://github.com/apache/spark/pull/44558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org