You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Timo Rantalaiho (JIRA)" <ji...@apache.org> on 2008/06/25 06:00:45 UTC
[jira] Created: (WICKET-1713) ModalWindow JavaScript does not
restore tabIndexes correctly on IE 6
ModalWindow JavaScript does not restore tabIndexes correctly on IE 6
--------------------------------------------------------------------
Key: WICKET-1713
URL: https://issues.apache.org/jira/browse/WICKET-1713
Project: Wicket
Issue Type: Bug
Components: wicket-extensions
Affects Versions: 1.4-M2, 1.3.3
Environment: IE 6, tested on Windows XP and CrossOver on Linux
Reporter: Timo Rantalaiho
Assignee: Timo Rantalaiho
Fix For: 1.3.5, 1.4-M3
Attached quickstart reproduces the problem before the fix. The problem is that if there are many input elements and some of them have tabindexes set, they are not restored properly when the modal window is closed.
It seems that when you do getElementsByTagName, IE 6 does not always return them in the same order.
I fixed this by using a custom javascript object property "hiddenTabIndex" to store the information directly to the manipulated element instead of the array. Object-oriented Javascript programming to save the world :)
It would be great if Matej and other javascript / ModalWindow experts could have a look!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-1713) ModalWindow JavaScript does not
restore tabIndexes correctly on IE 6
Posted by "Timo Rantalaiho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timo Rantalaiho reassigned WICKET-1713:
---------------------------------------
Assignee: Matej Knopp (was: Timo Rantalaiho)
Would be great if you could check if this makes sense
> ModalWindow JavaScript does not restore tabIndexes correctly on IE 6
> --------------------------------------------------------------------
>
> Key: WICKET-1713
> URL: https://issues.apache.org/jira/browse/WICKET-1713
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.3, 1.4-M2
> Environment: IE 6, tested on Windows XP and CrossOver on Linux
> Reporter: Timo Rantalaiho
> Assignee: Matej Knopp
> Fix For: 1.3.5, 1.4-M3
>
> Attachments: modal-window-tabindex-problem.zip
>
>
> Attached quickstart reproduces the problem before the fix. The problem is that if there are many input elements and some of them have tabindexes set, they are not restored properly when the modal window is closed.
> It seems that when you do getElementsByTagName, IE 6 does not always return them in the same order.
> I fixed this by using a custom javascript object property "hiddenTabIndex" to store the information directly to the manipulated element instead of the array. Object-oriented Javascript programming to save the world :)
> It would be great if Matej and other javascript / ModalWindow experts could have a look!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1713) ModalWindow JavaScript does not
restore tabIndexes correctly on IE 6
Posted by "Timo Rantalaiho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timo Rantalaiho updated WICKET-1713:
------------------------------------
Attachment: (was: modal-window-tabindex-problem.zip)
> ModalWindow JavaScript does not restore tabIndexes correctly on IE 6
> --------------------------------------------------------------------
>
> Key: WICKET-1713
> URL: https://issues.apache.org/jira/browse/WICKET-1713
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.3, 1.4-M2
> Environment: IE 6, tested on Windows XP and CrossOver on Linux
> Reporter: Timo Rantalaiho
> Assignee: Timo Rantalaiho
> Fix For: 1.3.5, 1.4-M3
>
> Attachments: modal-window-tabindex-problem.zip
>
>
> Attached quickstart reproduces the problem before the fix. The problem is that if there are many input elements and some of them have tabindexes set, they are not restored properly when the modal window is closed.
> It seems that when you do getElementsByTagName, IE 6 does not always return them in the same order.
> I fixed this by using a custom javascript object property "hiddenTabIndex" to store the information directly to the manipulated element instead of the array. Object-oriented Javascript programming to save the world :)
> It would be great if Matej and other javascript / ModalWindow experts could have a look!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1713) ModalWindow JavaScript does not
restore tabIndexes correctly on IE 6
Posted by "Timo Rantalaiho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timo Rantalaiho updated WICKET-1713:
------------------------------------
Attachment: modal-window-tabindex-problem.zip
To reproduce the problem, move from one text field to another with tab on IE, click "Show modal window", close the modal window, and try moving from one text field to another with tab again
> ModalWindow JavaScript does not restore tabIndexes correctly on IE 6
> --------------------------------------------------------------------
>
> Key: WICKET-1713
> URL: https://issues.apache.org/jira/browse/WICKET-1713
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.3, 1.4-M2
> Environment: IE 6, tested on Windows XP and CrossOver on Linux
> Reporter: Timo Rantalaiho
> Assignee: Timo Rantalaiho
> Fix For: 1.3.5, 1.4-M3
>
> Attachments: modal-window-tabindex-problem.zip
>
>
> Attached quickstart reproduces the problem before the fix. The problem is that if there are many input elements and some of them have tabindexes set, they are not restored properly when the modal window is closed.
> It seems that when you do getElementsByTagName, IE 6 does not always return them in the same order.
> I fixed this by using a custom javascript object property "hiddenTabIndex" to store the information directly to the manipulated element instead of the array. Object-oriented Javascript programming to save the world :)
> It would be great if Matej and other javascript / ModalWindow experts could have a look!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1713) ModalWindow JavaScript does not
restore tabIndexes correctly on IE 6
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608948#action_12608948 ]
Matej Knopp commented on WICKET-1713:
-------------------------------------
Hi, sorry for late response. Looks good to me.
> ModalWindow JavaScript does not restore tabIndexes correctly on IE 6
> --------------------------------------------------------------------
>
> Key: WICKET-1713
> URL: https://issues.apache.org/jira/browse/WICKET-1713
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.3, 1.4-M2
> Environment: IE 6, tested on Windows XP and CrossOver on Linux
> Reporter: Timo Rantalaiho
> Assignee: Matej Knopp
> Fix For: 1.3.5, 1.4-M3
>
> Attachments: modal-window-tabindex-problem.zip
>
>
> Attached quickstart reproduces the problem before the fix. The problem is that if there are many input elements and some of them have tabindexes set, they are not restored properly when the modal window is closed.
> It seems that when you do getElementsByTagName, IE 6 does not always return them in the same order.
> I fixed this by using a custom javascript object property "hiddenTabIndex" to store the information directly to the manipulated element instead of the array. Object-oriented Javascript programming to save the world :)
> It would be great if Matej and other javascript / ModalWindow experts could have a look!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1713) ModalWindow JavaScript does not
restore tabIndexes correctly on IE 6
Posted by "Timo Rantalaiho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timo Rantalaiho resolved WICKET-1713.
-------------------------------------
Resolution: Fixed
Interesting, I tried svn.eu.apache.org for the 1.3.x commit, but it seems like it does not come up in the Subversion commits tab. Maybe it's better not to use the EU mirror then.
> ModalWindow JavaScript does not restore tabIndexes correctly on IE 6
> --------------------------------------------------------------------
>
> Key: WICKET-1713
> URL: https://issues.apache.org/jira/browse/WICKET-1713
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.3, 1.4-M2
> Environment: IE 6, tested on Windows XP and CrossOver on Linux
> Reporter: Timo Rantalaiho
> Assignee: Timo Rantalaiho
> Fix For: 1.3.5, 1.4-M3
>
> Attachments: modal-window-tabindex-problem.zip
>
>
> Attached quickstart reproduces the problem before the fix. The problem is that if there are many input elements and some of them have tabindexes set, they are not restored properly when the modal window is closed.
> It seems that when you do getElementsByTagName, IE 6 does not always return them in the same order.
> I fixed this by using a custom javascript object property "hiddenTabIndex" to store the information directly to the manipulated element instead of the array. Object-oriented Javascript programming to save the world :)
> It would be great if Matej and other javascript / ModalWindow experts could have a look!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1713) ModalWindow JavaScript does not
restore tabIndexes correctly on IE 6
Posted by "Timo Rantalaiho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607850#action_12607850 ]
Timo Rantalaiho commented on WICKET-1713:
-----------------------------------------
Ah there it is, just with some delay.
> ModalWindow JavaScript does not restore tabIndexes correctly on IE 6
> --------------------------------------------------------------------
>
> Key: WICKET-1713
> URL: https://issues.apache.org/jira/browse/WICKET-1713
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.3, 1.4-M2
> Environment: IE 6, tested on Windows XP and CrossOver on Linux
> Reporter: Timo Rantalaiho
> Assignee: Timo Rantalaiho
> Fix For: 1.3.5, 1.4-M3
>
> Attachments: modal-window-tabindex-problem.zip
>
>
> Attached quickstart reproduces the problem before the fix. The problem is that if there are many input elements and some of them have tabindexes set, they are not restored properly when the modal window is closed.
> It seems that when you do getElementsByTagName, IE 6 does not always return them in the same order.
> I fixed this by using a custom javascript object property "hiddenTabIndex" to store the information directly to the manipulated element instead of the array. Object-oriented Javascript programming to save the world :)
> It would be great if Matej and other javascript / ModalWindow experts could have a look!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1713) ModalWindow JavaScript does not
restore tabIndexes correctly on IE 6
Posted by "Timo Rantalaiho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timo Rantalaiho updated WICKET-1713:
------------------------------------
Attachment: modal-window-tabindex-problem.zip
A quickstart reproducing a further problem that occurs when elements with stored tabindexes are updated via ajax
> ModalWindow JavaScript does not restore tabIndexes correctly on IE 6
> --------------------------------------------------------------------
>
> Key: WICKET-1713
> URL: https://issues.apache.org/jira/browse/WICKET-1713
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.3, 1.4-M2
> Environment: IE 6, tested on Windows XP and CrossOver on Linux
> Reporter: Timo Rantalaiho
> Assignee: Timo Rantalaiho
> Fix For: 1.3.5, 1.4-M3
>
> Attachments: modal-window-tabindex-problem.zip
>
>
> Attached quickstart reproduces the problem before the fix. The problem is that if there are many input elements and some of them have tabindexes set, they are not restored properly when the modal window is closed.
> It seems that when you do getElementsByTagName, IE 6 does not always return them in the same order.
> I fixed this by using a custom javascript object property "hiddenTabIndex" to store the information directly to the manipulated element instead of the array. Object-oriented Javascript programming to save the world :)
> It would be great if Matej and other javascript / ModalWindow experts could have a look!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.