[jira] [Commented] (BEAM-3369) Python HEAD fails tests due to a ValueError

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297350#comment-16297350 ] 

ASF GitHub Bot commented on BEAM-3369:
--------------------------------------

robertwb opened a new pull request #4292: [BEAM-3369] Fix typehint errors introduced in PR #4282.
URL: https://github.com/apache/beam/pull/4292
 
 
   This gets the tests passing (and fixes the lint error).
   A more principled fix will be in a follow-up PR.
   
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Python HEAD fails tests due to a ValueError 
> --------------------------------------------
>
>                 Key: BEAM-3369
>                 URL: https://issues.apache.org/jira/browse/BEAM-3369
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>    Affects Versions: Not applicable
>            Reporter: Chamikara Jayalath
>            Assignee: Robert Bradshaw
>            Priority: Critical
>
> tfidf_test.py is failing. Full error message is given below.
> ValueError: The key coder "TupleCoder[BytesCoder, FastPrimitivesCoder]" for GroupByKey operation "GroupByKey" is not deterministic. This may result in incorrect pipeline output. This can be fixed by adding a type hint to the operation preceding the GroupByKey step, and for custom key classes, by writing a deterministic custom Coder. Please see the documentation for more details.
> Seems to be due to following commit (passes without that).
> https://github.com/apache/beam/commit/1acd1ae901eefbcc8249d90e12ca82db0f91e41e#commitcomment-26356503
> Robert, can you take a look ?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)