You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by josh-howes <gi...@git.apache.org> on 2016/06/17 00:51:51 UTC

[GitHub] spark pull request #13724: [SPARK-15973] [PYSPARK] Fix GroupedData Documenta...

GitHub user josh-howes opened a pull request:

    https://github.com/apache/spark/pull/13724

    [SPARK-15973] [PYSPARK] Fix GroupedData Documentation

    *This contribution is my original work and that I license the work to the project under the project's open source license.*
    
    ## What changes were proposed in this pull request?
    
    Documentation updates to PySpark's GroupedData
    
    
    ## How was this patch tested?
    
    Manual Tests
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/josh-howes/spark bugfix/SPARK-15973

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/13724.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13724
    
----
commit fc2ed435690b72308c0ed480e799ee427bb3c12a
Author: Josh Howes <jo...@gmail.com>
Date:   2016-06-17T00:27:32Z

    Update pyspark doc to use # vs. // in

commit 649f3055824649826f0c066252fffd867c88747a
Author: Josh Howes <jo...@gmail.com>
Date:   2016-06-17T00:37:51Z

    Rename wrapped java object in  to be _jgd ('Java Grouped Data') vs. _jdf

commit 8f3ea3ef0820870dce582ea9ccbc53d7db490768
Author: Josh Howes <jo...@gmail.com>
Date:   2016-06-17T00:43:11Z

    Rename  varargs to match 'cols' in documentation

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13724: [SPARK-15973] [PYSPARK] Fix GroupedData Documentation

Posted by josh-howes <gi...@git.apache.org>.

Github user josh-howes commented on the issue:

    https://github.com/apache/spark/pull/13724
  
    Hello, first commit here.  Trying to get started by tackling some "trival" tickets around documentation.  I'm at a loss about how my changes are causing the unit tests to fail in `types.py`.  Any help would be appreciated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13724: [SPARK-15973] [PYSPARK] Fix GroupedData Documentation

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/13724
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13724: [SPARK-15973] [PYSPARK] Fix GroupedData Documentation

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/13724
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60703/
    Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13724: [SPARK-15973] [PYSPARK] Fix GroupedData Documentation

Posted by MLnick <gi...@git.apache.org>.

Github user MLnick commented on the issue:

    https://github.com/apache/spark/pull/13724
  
    ok to test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13724: [SPARK-15973] [PYSPARK] Fix GroupedData Documentation

Posted by rxin <gi...@git.apache.org>.

Github user rxin commented on the issue:

    https://github.com/apache/spark/pull/13724
  
    Thanks - merging in master/2.0.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13724: [SPARK-15973] [PYSPARK] Fix GroupedData Documentation

Posted by vlad17 <gi...@git.apache.org>.

Github user vlad17 commented on the issue:

    https://github.com/apache/spark/pull/13724
  
    The issue is that there are still some references to the old `GroupedData._jdf` attribute - if you click on the the Jenkins link you'll find where (but I pasted below too):
    Error Message
    
    ```
    'GroupedData' object has no attribute '_jdf'
    Stacktrace
    
    Traceback (most recent call last):
      File "/home/jenkins/workspace/SparkPullRequestBuilder/python/pyspark/sql/tests.py", line 682, in test_aggregator
        self.assertEqual([Row(**{"AVG(key#0)": 49.5})], g.mean().collect())
      File "/home/jenkins/workspace/SparkPullRequestBuilder/python/pyspark/sql/group.py", line 40, in _api
        jdf = getattr(self._jdf, name)(_to_seq(self.sql_ctx._sc, cols))
    AttributeError: 'GroupedData' object has no attribute '_jdf'
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13724: [SPARK-15973] [PYSPARK] Fix GroupedData Documentation

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/13724
  
    **[Test build #60719 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60719/consoleFull)** for PR 13724 at commit [`9e9363d`](https://github.com/apache/spark/commit/9e9363db3e2cf24cae2f02e421aecec73168a2e6).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13724: [SPARK-15973] [PYSPARK] Fix GroupedData Documentation

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/13724
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13724: [SPARK-15973] [PYSPARK] Fix GroupedData Documentation

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/13724
  
    **[Test build #60703 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60703/consoleFull)** for PR 13724 at commit [`8f3ea3e`](https://github.com/apache/spark/commit/8f3ea3ef0820870dce582ea9ccbc53d7db490768).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13724: [SPARK-15973] [PYSPARK] Fix GroupedData Documentation

Posted by josh-howes <gi...@git.apache.org>.

Github user josh-howes commented on the issue:

    https://github.com/apache/spark/pull/13724
  
    @rxin, I just created a ASF Jira Account.  I didn't have one previously.  Here's my info: full name is Josh Howes and username is (josh dot howes at gmail dot com).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13724: [SPARK-15973] [PYSPARK] Fix GroupedData Documentation

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/13724
  
    **[Test build #60719 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60719/consoleFull)** for PR 13724 at commit [`9e9363d`](https://github.com/apache/spark/commit/9e9363db3e2cf24cae2f02e421aecec73168a2e6).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13724: [SPARK-15973] [PYSPARK] Fix GroupedData Documentation

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/13724
  
    **[Test build #60703 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60703/consoleFull)** for PR 13724 at commit [`8f3ea3e`](https://github.com/apache/spark/commit/8f3ea3ef0820870dce582ea9ccbc53d7db490768).
     * This patch **fails PySpark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org