You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whirr.apache.org by "Steve Loughran (JIRA)" <ji...@apache.org> on 2012/09/14 12:59:07 UTC

[jira] [Created] (WHIRR-653) Script exit codes aren't being checked

Steve Loughran created WHIRR-653:
------------------------------------

             Summary: Script exit codes aren't being checked
                 Key: WHIRR-653
                 URL: https://issues.apache.org/jira/browse/WHIRR-653
             Project: Whirr
          Issue Type: Bug
          Components: core
    Affects Versions: 0.9.0
         Environment: local: OSX, remote RHEL6.3
            Reporter: Steve Loughran
            Priority: Critical


My installer script bails out with an {{exit 1}} on many operations, such as
{{chown -R hadoop:hadoop $HADOOP_PID_DIR  || exit 1;}}
This is to find problems early and so aid debugging of the installation.

Even when a script fails this way, Whirr declares that the installation was successful. 

It must check the return codes to be confident that the operation succeeded.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (WHIRR-653) Script exit codes aren't being checked

Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WHIRR-653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Loughran updated WHIRR-653:
---------------------------------

    Attachment: whirr-653.patch
    
> Script exit codes aren't being checked
> --------------------------------------
>
>                 Key: WHIRR-653
>                 URL: https://issues.apache.org/jira/browse/WHIRR-653
>             Project: Whirr
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.9.0
>         Environment: local: OSX, remote RHEL6.3
>            Reporter: Steve Loughran
>            Priority: Critical
>         Attachments: whirr-653.patch
>
>
> My installer script bails out with an {{exit 1}} on many operations, such as
> {{chown -R hadoop:hadoop $HADOOP_PID_DIR  || exit 1;}}
> This is to find problems early and so aid debugging of the installation.
> Even when a script fails this way, Whirr declares that the installation was successful. 
> It must check the return codes to be confident that the operation succeeded.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (WHIRR-653) Script exit codes aren't being checked

Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WHIRR-653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Loughran updated WHIRR-653:
---------------------------------

    Attachment: whirr-654.txt

This converts error results into exceptions. However it causes problems with the outer classes that want to spin until the script succeeds. Guess what: it isn't going to.
                
> Script exit codes aren't being checked
> --------------------------------------
>
>                 Key: WHIRR-653
>                 URL: https://issues.apache.org/jira/browse/WHIRR-653
>             Project: Whirr
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.9.0
>         Environment: local: OSX, remote RHEL6.3
>            Reporter: Steve Loughran
>            Priority: Critical
>         Attachments: whirr-654.txt
>
>
> My installer script bails out with an {{exit 1}} on many operations, such as
> {{chown -R hadoop:hadoop $HADOOP_PID_DIR  || exit 1;}}
> This is to find problems early and so aid debugging of the installation.
> Even when a script fails this way, Whirr declares that the installation was successful. 
> It must check the return codes to be confident that the operation succeeded.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WHIRR-653) Script exit codes aren't being checked

Posted by "Karel Vervaeke (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WHIRR-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455747#comment-13455747 ] 

Karel Vervaeke commented on WHIRR-653:
--------------------------------------

I don't know if you can get the exit code via the API (not saying you can't - I just don't know), but the scripts leave behind an 'rc' file containing the exit code.
e.g. /tmp/bootstrap-.../rc
                
> Script exit codes aren't being checked
> --------------------------------------
>
>                 Key: WHIRR-653
>                 URL: https://issues.apache.org/jira/browse/WHIRR-653
>             Project: Whirr
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.9.0
>         Environment: local: OSX, remote RHEL6.3
>            Reporter: Steve Loughran
>            Priority: Critical
>
> My installer script bails out with an {{exit 1}} on many operations, such as
> {{chown -R hadoop:hadoop $HADOOP_PID_DIR  || exit 1;}}
> This is to find problems early and so aid debugging of the installation.
> Even when a script fails this way, Whirr declares that the installation was successful. 
> It must check the return codes to be confident that the operation succeeded.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (WHIRR-653) Script exit codes aren't being checked

Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WHIRR-653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Loughran updated WHIRR-653:
---------------------------------

    Attachment:     (was: whirr-654.txt)
    
> Script exit codes aren't being checked
> --------------------------------------
>
>                 Key: WHIRR-653
>                 URL: https://issues.apache.org/jira/browse/WHIRR-653
>             Project: Whirr
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.9.0
>         Environment: local: OSX, remote RHEL6.3
>            Reporter: Steve Loughran
>            Priority: Critical
>         Attachments: whirr-653.patch
>
>
> My installer script bails out with an {{exit 1}} on many operations, such as
> {{chown -R hadoop:hadoop $HADOOP_PID_DIR  || exit 1;}}
> This is to find problems early and so aid debugging of the installation.
> Even when a script fails this way, Whirr declares that the installation was successful. 
> It must check the return codes to be confident that the operation succeeded.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WHIRR-653) Script exit codes aren't being checked

Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WHIRR-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458562#comment-13458562 ] 

Andrei Savu commented on WHIRR-653:
-----------------------------------

I think it's a good idea to retry the script execution on a new machine on failure as configured by whirr.max-startup-retries. We also need a way to check the exit code for bootstrap phase scripts. 
                
> Script exit codes aren't being checked
> --------------------------------------
>
>                 Key: WHIRR-653
>                 URL: https://issues.apache.org/jira/browse/WHIRR-653
>             Project: Whirr
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.9.0
>         Environment: local: OSX, remote RHEL6.3
>            Reporter: Steve Loughran
>            Priority: Critical
>         Attachments: whirr-653.patch
>
>
> My installer script bails out with an {{exit 1}} on many operations, such as
> {{chown -R hadoop:hadoop $HADOOP_PID_DIR  || exit 1;}}
> This is to find problems early and so aid debugging of the installation.
> Even when a script fails this way, Whirr declares that the installation was successful. 
> It must check the return codes to be confident that the operation succeeded.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira