You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "tanmayrauth (via GitHub)" <gi...@apache.org> on 2026/05/20 09:45:28 UTC
[PR] feat(table): reject AddDataFiles on v3 when first_row_id is missing (#1000) [iceberg-go]
tanmayrauth opened a new pull request, #1101:
URL: https://github.com/apache/iceberg-go/pull/1101
Closes #1000
When users call `AddDataFiles` (or `ReplaceDataFilesWithDataFiles` / `ReplaceFiles`) with externally-written parquet files on a v3 table, reject the operation if `first_row_id` is not set. This mirrors
pyiceberg's behavior — the library cannot fabricate row IDs retroactively, so callers must supply them explicitly via `DataFileBuilder.FirstRowID()`.
## Changes
- Added validation in `validateDataFilesToAdd` to require `first_row_id` on format version >= 3
- Error message directs users to `DataFileBuilder.FirstRowID()`
- v2 tables are unaffected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat(table): reject AddDataFiles on v3 when first_row_id is missing (#1000) [iceberg-go]
Posted by "tanmayrauth (via GitHub)" <gi...@apache.org>.
tanmayrauth commented on PR #1101:
URL: https://github.com/apache/iceberg-go/pull/1101#issuecomment-4499985247
@laskoviymishka can you please review it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat(table): reject AddDataFiles on v3 when first_row_id is missing (#1000) [iceberg-go]
Posted by "tanmayrauth (via GitHub)" <gi...@apache.org>.
tanmayrauth commented on PR #1101:
URL: https://github.com/apache/iceberg-go/pull/1101#issuecomment-4508789195
@laskoviymishka could you please review it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat(table): reject AddDataFiles on v3 when first_row_id is missing (#1000) [iceberg-go]
Posted by "laskoviymishka (via GitHub)" <gi...@apache.org>.
laskoviymishka merged PR #1101:
URL: https://github.com/apache/iceberg-go/pull/1101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org