You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by "dsoumis (via GitHub)" <gi...@apache.org> on 2024/06/23 14:47:40 UTC
[PR] Increase test coverage of WsServerContainer [tomcat]
dsoumis opened a new pull request, #736:
URL: https://github.com/apache/tomcat/pull/736
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] Increase test coverage of WsServerContainer [tomcat]
Posted by "rmaucher (via GitHub)" <gi...@apache.org>.
rmaucher commented on PR #736:
URL: https://github.com/apache/tomcat/pull/736#issuecomment-2186070382
Did you add "execute.validate=true" to your build.properties file ? Normally we don't use wildcard imports (please avoid that part).
Other than that, more test coverage = good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] Increase test coverage of WsServerContainer [tomcat]
Posted by "dsoumis (via GitHub)" <gi...@apache.org>.
dsoumis commented on PR #736:
URL: https://github.com/apache/tomcat/pull/736#issuecomment-2186443680
Thanks for pointing that out. I've applied the fixes required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] Increase test coverage of WsServerContainer [tomcat]
Posted by "JanFojtik21 (via GitHub)" <gi...@apache.org>.
JanFojtik21 commented on PR #736:
URL: https://github.com/apache/tomcat/pull/736#issuecomment-2186446656
okey, then all good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org