You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Steve Loughran <st...@apache.org> on 2007/01/29 18:08:17 UTC

tarfileset nested vs standalone

in the standalone <tarfileset> datatype, you cant go

<tarfileset mode="755" id="something" />

the way you do inside <tar>, you have to go

<tarfileset filemode="755" id="something" />


Isnt that a bit, well, inconsistent?

-steve


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Re: tarfileset nested vs standalone

Posted by Stefan Bodewig <bo...@apache.org>.
On Tue, 30 Jan 2007, Steve Loughran <st...@apache.org> wrote:

> how long has filemode been in tar/tarfileset? Does it work in 1.6.x?

It is not in 1.6.5, no.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Re: tarfileset nested vs standalone

Posted by Steve Loughran <st...@apache.org>.
Stefan Bodewig wrote:

> On Mon, 29 Jan 2007, Steve Loughran <st...@apache.org> wrote:
>> in the standalone <tarfileset> datatype, you cant go
>>
>> <tarfileset mode="755" id="something" />
>>
>> the way you do inside <tar>, you have to go
>>
>> <tarfileset filemode="755" id="something" />
> 
> You mean the other way around, mode in <tar> and filemode outside.
> Actually, you can use filemode in both places.
> 
> The reason (as usual) is backwards compatibility.  <zipfileset> always
> used "filemode" while the <tarfileset> nested into <tar> used "mode".
> 
> The standalone version of <tarfileset> shares code with <zipfileset>
> and thus now has a filemode attribute.  The <tarfileset> inside <tar>
> corresponds to a subclass of the standalone one that delegates
> setMode() to setFileMode() in its base class.
> 
>> Isnt that a bit, well, inconsistent?
> 
> We should promote using filemode in either place.

how long has filemode been in tar/tarfileset? Does it work in 1.6.x?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Re: tarfileset nested vs standalone

Posted by Stefan Bodewig <bo...@apache.org>.
On Mon, 29 Jan 2007, Steve Loughran <st...@apache.org> wrote:
> in the standalone <tarfileset> datatype, you cant go
> 
> <tarfileset mode="755" id="something" />
> 
> the way you do inside <tar>, you have to go
> 
> <tarfileset filemode="755" id="something" />

You mean the other way around, mode in <tar> and filemode outside.
Actually, you can use filemode in both places.

The reason (as usual) is backwards compatibility.  <zipfileset> always
used "filemode" while the <tarfileset> nested into <tar> used "mode".

The standalone version of <tarfileset> shares code with <zipfileset>
and thus now has a filemode attribute.  The <tarfileset> inside <tar>
corresponds to a subclass of the standalone one that delegates
setMode() to setFileMode() in its base class.

> Isnt that a bit, well, inconsistent?

We should promote using filemode in either place.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Re: tarfileset nested vs standalone

Posted by Peter Reilly <pe...@gmail.com>.
Yes,
It is a bit strange.

Peter

On 1/29/07, Steve Loughran <st...@apache.org> wrote:
>
> in the standalone <tarfileset> datatype, you cant go
>
> <tarfileset mode="755" id="something" />
>
> the way you do inside <tar>, you have to go
>
> <tarfileset filemode="755" id="something" />
>
>
> Isnt that a bit, well, inconsistent?
>
> -steve
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org