You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/06 07:12:09 UTC

[GitHub] [spark] maropu opened a new pull request #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references

maropu opened a new pull request #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references
URL: https://github.com/apache/spark/pull/28134
 
 
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   This PR intends to improve the SQL document of `GROUP BY`; it added the description about FILTER clauses of aggregate functions.
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   To improve the SQL documents
   
   ### Does this PR introduce any user-facing change?
   <!--
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If no, write 'No'.
   -->
   Yes.
   
   <img src="https://user-images.githubusercontent.com/692303/78531636-c35a8f00-7820-11ea-9406-fb60e1998a85.png" width="500">
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   Manually checked.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] beliefer commented on a change in pull request #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references

Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references
URL: https://github.com/apache/spark/pull/28134#discussion_r404131336
 
 

 ##########
 File path: docs/sql-ref-syntax-qry-select-groupby.md
 ##########
 @@ -70,6 +76,19 @@ GROUP BY GROUPING SETS (grouping_set [ , ...])
     ((warehouse, product), (warehouse), (product), ())</code>.
     The N elements of a <code>CUBE</code> specification results in 2^N <code>GROUPING SETS</code>.
   </dd>
+  <dt><code><em>aggregate_name</em></code></dt>
+  <dd>
+    Specifies an aggregate function name (MIN, MAX, COUNT, SUM, AVG, etc.).
+  </dd>
+  <dt><code><em>DISTINCT</em></code></dt>
+  <dd>
+    Removes duplicates in input rows before they are passed to aggregate functions.
+  </dd>
+  <dt><code><em>FILTER</em></code></dt>
+  <dd>
+    Filters the input rows for which the <code>boolean_expression</code> in the <code>WHERE</code> clause evaluates
 
 Review comment:
   Could we change <code>WHERE</code> to <code>FILTER</code>.
   Because WHERE clause causes confusion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references

Posted by GitBox <gi...@apache.org>.
maropu commented on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references
URL: https://github.com/apache/spark/pull/28134#issuecomment-609607876
 
 
   cc: @cloud-fan @huaxingao @beliefer

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references
URL: https://github.com/apache/spark/pull/28134#issuecomment-609607856
 
 
   **[Test build #120861 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120861/testReport)** for PR 28134 at commit [`8d50a6e`](https://github.com/apache/spark/commit/8d50a6eb063551afeac88ce90886b60a21cbf1aa).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references
URL: https://github.com/apache/spark/pull/28134#issuecomment-609608379
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references
URL: https://github.com/apache/spark/pull/28134#issuecomment-609608386
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25555/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references
URL: https://github.com/apache/spark/pull/28134#issuecomment-609608386
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25555/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references
URL: https://github.com/apache/spark/pull/28134#issuecomment-609613589
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120861/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on a change in pull request #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references
URL: https://github.com/apache/spark/pull/28134#discussion_r403951469
 
 

 ##########
 File path: docs/sql-ref-syntax-qry-select-groupby.md
 ##########
 @@ -70,6 +76,15 @@ GROUP BY GROUPING SETS (grouping_set [ , ...])
     ((warehouse, product), (warehouse), (product), ())</code>.
     The N elements of a <code>CUBE</code> specification results in 2^N <code>GROUPING SETS</code>.
   </dd>
+  <dt><code><em>aggregate_name</em></code></dt>
+  <dd>
+    Specifies an aggregate function name (MIN, MAX, COUNT, SUM, AVG, etc.).
+  </dd>
+  <dt><code><em>FILTER</em></code></dt>
 
 Review comment:
   ok, I'll add.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] beliefer commented on a change in pull request #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references

Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references
URL: https://github.com/apache/spark/pull/28134#discussion_r404131336
 
 

 ##########
 File path: docs/sql-ref-syntax-qry-select-groupby.md
 ##########
 @@ -70,6 +76,19 @@ GROUP BY GROUPING SETS (grouping_set [ , ...])
     ((warehouse, product), (warehouse), (product), ())</code>.
     The N elements of a <code>CUBE</code> specification results in 2^N <code>GROUPING SETS</code>.
   </dd>
+  <dt><code><em>aggregate_name</em></code></dt>
+  <dd>
+    Specifies an aggregate function name (MIN, MAX, COUNT, SUM, AVG, etc.).
+  </dd>
+  <dt><code><em>DISTINCT</em></code></dt>
+  <dd>
+    Removes duplicates in input rows before they are passed to aggregate functions.
+  </dd>
+  <dt><code><em>FILTER</em></code></dt>
+  <dd>
+    Filters the input rows for which the <code>boolean_expression</code> in the <code>WHERE</code> clause evaluates
 
 Review comment:
   Could we change <code>WHERE</code> to <code>FILTER</code>.
   Because `WHERE clause` causes confusion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references
URL: https://github.com/apache/spark/pull/28134#issuecomment-609613418
 
 
   **[Test build #120861 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120861/testReport)** for PR 28134 at commit [`8d50a6e`](https://github.com/apache/spark/commit/8d50a6eb063551afeac88ce90886b60a21cbf1aa).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] beliefer commented on a change in pull request #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references

Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references
URL: https://github.com/apache/spark/pull/28134#discussion_r404133861
 
 

 ##########
 File path: docs/sql-ref-syntax-qry-select-groupby.md
 ##########
 @@ -70,6 +76,19 @@ GROUP BY GROUPING SETS (grouping_set [ , ...])
     ((warehouse, product), (warehouse), (product), ())</code>.
     The N elements of a <code>CUBE</code> specification results in 2^N <code>GROUPING SETS</code>.
   </dd>
+  <dt><code><em>aggregate_name</em></code></dt>
+  <dd>
+    Specifies an aggregate function name (MIN, MAX, COUNT, SUM, AVG, etc.).
+  </dd>
+  <dt><code><em>DISTINCT</em></code></dt>
+  <dd>
+    Removes duplicates in input rows before they are passed to aggregate functions.
+  </dd>
+  <dt><code><em>FILTER</em></code></dt>
+  <dd>
+    Filters the input rows for which the <code>boolean_expression</code> in the <code>WHERE</code> clause evaluates
+    to true are passed to the aggregate function; other rows are discarded.
 
 Review comment:
   `other rows are discarded` to `other rows are not passed`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a change in pull request #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references
URL: https://github.com/apache/spark/pull/28134#discussion_r403938994
 
 

 ##########
 File path: docs/sql-ref-syntax-qry-select-groupby.md
 ##########
 @@ -70,6 +76,15 @@ GROUP BY GROUPING SETS (grouping_set [ , ...])
     ((warehouse, product), (warehouse), (product), ())</code>.
     The N elements of a <code>CUBE</code> specification results in 2^N <code>GROUPING SETS</code>.
   </dd>
+  <dt><code><em>aggregate_name</em></code></dt>
+  <dd>
+    Specifies an aggregate function name (MIN, MAX, COUNT, SUM, AVG, etc.).
+  </dd>
+  <dt><code><em>FILTER</em></code></dt>
 
 Review comment:
   not related to this PR but would be great to explain DISTINCT as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] beliefer commented on a change in pull request #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references

Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references
URL: https://github.com/apache/spark/pull/28134#discussion_r404136338
 
 

 ##########
 File path: docs/sql-ref-syntax-qry-select-groupby.md
 ##########
 @@ -120,6 +139,31 @@ SELECT id, sum(quantity) AS sum, max(quantity) AS max FROM dealer GROUP BY id OR
   |300|13 |8  |
   +---+---+---+
 
+-- Count the number of distinct dealer cities per car_model.
+SELECT car_model, count(DISTINCT city) AS count FROM dealer GROUP BY car_model;
+
+  +------------+-----+
+  |   car_model|count|
+  +------------+-----+
+  | Honda Civic|    3|
+  |   Honda CRV|    2|
+  |Honda Accord|    3|
+  +------------+-----+
+
+-- Sum of only 'Honda Civic' and 'Honda CRV' quantities per dealership.
+SELECT id, sum(quantity) FILTER (
+            WHERE car_model IN ('Honda Civic', 'Honda CRV')
+        ) AS `sum(quantity)` FROM dealer
+    GROUP BY id ORDER BY id;
 
 Review comment:
   ```
   SELECT
        id,
        SUM(quantity) FILTER (WHERE car_model IN ('Honda Civic', 'Honda CRV')) AS `sum(quantity)`
   FROM dealer
   GROUP BY id ORDER BY id;
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references
URL: https://github.com/apache/spark/pull/28134#issuecomment-609613589
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120861/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu closed pull request #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references

Posted by GitBox <gi...@apache.org>.
maropu closed pull request #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references
URL: https://github.com/apache/spark/pull/28134
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references
URL: https://github.com/apache/spark/pull/28134#issuecomment-609768011
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120873/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references
URL: https://github.com/apache/spark/pull/28134#issuecomment-609768000
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references
URL: https://github.com/apache/spark/pull/28134#issuecomment-609613577
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references
URL: https://github.com/apache/spark/pull/28134#issuecomment-609768000
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references
URL: https://github.com/apache/spark/pull/28134#issuecomment-609607856
 
 
   **[Test build #120861 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120861/testReport)** for PR 28134 at commit [`8d50a6e`](https://github.com/apache/spark/commit/8d50a6eb063551afeac88ce90886b60a21cbf1aa).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references
URL: https://github.com/apache/spark/pull/28134#issuecomment-609608379
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references
URL: https://github.com/apache/spark/pull/28134#issuecomment-609613577
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references

Posted by GitBox <gi...@apache.org>.
maropu commented on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references
URL: https://github.com/apache/spark/pull/28134#issuecomment-609768696
 
 
   Since the latest commit is pretty minimal, I've merged to master/3.0. Thanks for the review, @cloud-fan .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu edited a comment on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references

Posted by GitBox <gi...@apache.org>.
maropu edited a comment on issue #28134: [SPARK-31358][SQL][DOC] Document FILTER clauses of aggregate functions in SQL references
URL: https://github.com/apache/spark/pull/28134#issuecomment-609607876
 
 
   cc: @huaxingao @cloud-fan  @beliefer

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org