You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2021/02/22 04:58:50 UTC
[GitHub] [guacamole-server] mike-jumper commented on a change in pull request #304: GUACAMOLE-141: Implement full support for keyboard-interactive authentication method.
mike-jumper commented on a change in pull request #304:
URL: https://github.com/apache/guacamole-server/pull/304#discussion_r579984839
##########
File path: src/common-ssh/ssh.c
##########
@@ -358,68 +350,63 @@ static int guac_common_ssh_authenticate(guac_common_ssh_session* common_session)
}
- /* Attempt authentication with username + password. */
- if (user->password == NULL && common_session->credential_handler)
- user->password = common_session->credential_handler(client, "Password: ");
-
- /* Authenticate with password, if provided */
- if (user->password != NULL) {
+ /* Check if keyboard-interactive auth is supported on the server */
+ if (strstr(user_authlist, "keyboard-interactive") != NULL &&
+ common_session->credential_handler != NULL) {
Review comment:
> @mike-jumper Thoughts, here - either technical or approach-wise for resolving this? Am I off-base here?
I agree with the concerns regarding the expected behavior when a password is provided in advance by the administrator. If the administrator provides a password, then that is the sole input that should be used for authentication unless there is some mechanism for the administrator to explicitly dictate otherwise.
I suggest:
1. Maintain the established behavior for cases where the password is provided in advance: prefer "password", use "keyboard-interactive" if needed and only if there is exactly one prompt.
2. If no password is provided in advance, use either authentication method and allow any number of "keyboard-interactive" prompts. It might make sense to prefer "keyboard-interactive" in this case.
The downside to the above would be that it would not be possible to automatically provide a password for SSH servers that use MFA, but it sounds like there is no safe approach for that case (at least not without more complex configuration that allows the administrator to _declare_ their expectations).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org