You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pluto-dev@portals.apache.org by "Vernon Singleton (JIRA)" <ji...@apache.org> on 2018/01/17 09:36:00 UTC
[jira] [Updated] (PLUTO-681) TCK: Contesting PortletTests
PortletConfig ApiRender getContainerRuntimeOptions which assumes exactly 2
options will be returned
[ https://issues.apache.org/jira/browse/PLUTO-681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vernon Singleton updated PLUTO-681:
-----------------------------------
Description:
The following tests assume that exactly 2 options will be returned by the getContainerRuntimeOptions method:
V2PortletTests_PortletConfig_ApiRender_getContainerRuntimeOptions1:
[https://github.com/apache/portals-pluto/blob/6f76532516a391233b21d8b192883db4333422d0/portlet-tck_3.0/V2PortletTests/src/main/java/javax/portlet/tck/portlets/PortletTests_PortletConfig_ApiRender.java#L342]
V2PortletTests_PortletConfig_ApiRender_getContainerRuntimeOptions2:
[https://github.com/apache/portals-pluto/blob/6f76532516a391233b21d8b192883db4333422d0/portlet-tck_3.0/V2PortletTests/src/main/java/javax/portlet/tck/portlets/PortletTests_PortletConfig_ApiRender.java#L370]
V2PortletTests_PortletConfig_ApiRender_getContainerRuntimeOptions3:
[https://github.com/apache/portals-pluto/blob/6f76532516a391233b21d8b192883db4333422d0/portlet-tck_3.0/V2PortletTests/src/main/java/javax/portlet/tck/portlets/PortletTests_PortletConfig_ApiRender.java#L397]
Since this number, *2*, appears to magically fit pluto's return size, but is unlikely to fit the return size of other containers, and since the tck only checks one of the returned options, it might be better to relax this requirement that portletConfig.getContainerRuntimeOptions().size() == 2.
This could simply be changed to > 1 instead of == 2.
Will send a PR in the comments with suggested fix for the tck.
> TCK: Contesting PortletTests PortletConfig ApiRender getContainerRuntimeOptions which assumes exactly 2 options will be returned
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: PLUTO-681
> URL: https://issues.apache.org/jira/browse/PLUTO-681
> Project: Pluto
> Issue Type: Bug
> Components: tck
> Affects Versions: 3.0.0
> Reporter: Vernon Singleton
> Assignee: Scott Nicklous
> Priority: Minor
>
> The following tests assume that exactly 2 options will be returned by the getContainerRuntimeOptions method:
> V2PortletTests_PortletConfig_ApiRender_getContainerRuntimeOptions1:
> [https://github.com/apache/portals-pluto/blob/6f76532516a391233b21d8b192883db4333422d0/portlet-tck_3.0/V2PortletTests/src/main/java/javax/portlet/tck/portlets/PortletTests_PortletConfig_ApiRender.java#L342]
> V2PortletTests_PortletConfig_ApiRender_getContainerRuntimeOptions2:
> [https://github.com/apache/portals-pluto/blob/6f76532516a391233b21d8b192883db4333422d0/portlet-tck_3.0/V2PortletTests/src/main/java/javax/portlet/tck/portlets/PortletTests_PortletConfig_ApiRender.java#L370]
> V2PortletTests_PortletConfig_ApiRender_getContainerRuntimeOptions3:
> [https://github.com/apache/portals-pluto/blob/6f76532516a391233b21d8b192883db4333422d0/portlet-tck_3.0/V2PortletTests/src/main/java/javax/portlet/tck/portlets/PortletTests_PortletConfig_ApiRender.java#L397]
> Since this number, *2*, appears to magically fit pluto's return size, but is unlikely to fit the return size of other containers, and since the tck only checks one of the returned options, it might be better to relax this requirement that portletConfig.getContainerRuntimeOptions().size() == 2.
> This could simply be changed to > 1 instead of == 2.
> Will send a PR in the comments with suggested fix for the tck.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)