You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@streampipes.apache.org by GitBox <gi...@apache.org> on 2021/10/09 06:05:50 UTC

[GitHub] [incubator-streampipes-extensions] tenthe commented on pull request #49: [STREAMPIPES-] Splitting streampipes-connect-adapters

tenthe commented on pull request #49:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/49#issuecomment-939235688


   Hi Hrushikesh,
   thanks a lot for providing the pull request :)
   
   I checked it out and tested it locally and everything worked fine.
   I have some minor changes for the code before I can merge the pull request:
   
   - In the ConnectAdapterInit you can also add all the adapters (e.g. Gdelt) that were commented out before
   - You can also delete all the classes and packages of the adapters that are not registered in the Init class. Currently the implementation of an adapter / protocol is in both packages.
   - Can you please remove the '/.idea/workspace.xml' file from the commit I think this is a file describing your local setup of IntelliJ.
   
   If you have any questions we can directly discuss them here.
   
   Philipp
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org