You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/23 11:12:24 UTC

[GitHub] [airflow] Taragolis opened a new pull request, #26628: Remove duplicated connection-type within the provider

Taragolis opened a new pull request, #26628:
URL: https://github.com/apache/airflow/pull/26628

   Remove duplicated connection type for amazon and databricks providers.
   
   `aws` provided by `airflow.providers.amazon.aws.hooks.base_aws.AwsGenericHook`
   `databricks` provided by `airflow.providers.databricks.hooks.databricks.DatabricksHook`
   
   Seem like the actual order in _connection-types_ in `provider.yaml` the only thing that really matter, if provider contains multiple different `hook-class-name` with the same `connection-type`:
   - The first `hook-class-name` with listed would use in the UI/API/CLI for fields names and testing connection
   - All other would be ignored, the warning only shows if same `connection-type` exists in the different providers
   
   https://github.com/apache/airflow/blob/55d11464c047d2e74f34cdde75d90b633a231df2/airflow/providers_manager.py#L529-L539
   
   Might be also good idea to warn users if already_registered  `connection-type` exists in the same provider.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk merged pull request #26628: Remove duplicated connection-type within the provider

Posted by GitBox <gi...@apache.org>.
potiuk merged PR #26628:
URL: https://github.com/apache/airflow/pull/26628


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org