You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2014/12/11 10:56:50 UTC
[GitHub] incubator-flink pull request: [FLINK-1310] Change ClosureCleaner L...
GitHub user aljoscha opened a pull request:
https://github.com/apache/incubator-flink/pull/262
[FLINK-1310] Change ClosureCleaner Logging to DEBUG
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/incubator-flink scala-closure-cleaner-debug-log
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-flink/pull/262.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #262
----
commit c91c4bc6fc9cb1551be91bf50dfd0e07df2e9bb2
Author: Aljoscha Krettek <al...@gmail.com>
Date: 2014-12-11T09:56:07Z
[FLINK-1310] Change ClosureCleaner Logging to DEBUG
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1310] Change ClosureCleaner L...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/262#discussion_r21690089
--- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/ClosureCleaner.scala ---
@@ -4,7 +4,7 @@
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
+ * "License") you may not use this file except in compliance
--- End diff --
Yeah, we have the header that we want hardcoded. No deviation allowed. :D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1310] Change ClosureCleaner L...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/262#discussion_r21689347
--- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/ClosureCleaner.scala ---
@@ -4,7 +4,7 @@
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
+ * "License") you may not use this file except in compliance
--- End diff --
Please do not remove the semicolon (;) from the license header.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1310] Change ClosureCleaner L...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/262#discussion_r21689770
--- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/ClosureCleaner.scala ---
@@ -4,7 +4,7 @@
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
+ * "License") you may not use this file except in compliance
--- End diff --
Yes, correct. I thought I fixed it, because the scalastyle plugin complained. Forgot to create the commit and push the update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1310] Change ClosureCleaner L...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-flink/pull/262
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1310] Change ClosureCleaner L...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/262#discussion_r21689877
--- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/ClosureCleaner.scala ---
@@ -4,7 +4,7 @@
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
+ * "License") you may not use this file except in compliance
--- End diff --
Wow scalastyle plugin complain about the typo? Impressive =)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---