[jira] [Commented] (YARN-9998) Code cleanup in LeveldbConfigurationStore

["Oleg Bonar (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-9998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16999872#comment-16999872 ] 

Oleg Bonar commented on YARN-9998:
----------------------------------

HI [~snemeth]. Is this still needed? If so, can I take it?

> Code cleanup in LeveldbConfigurationStore
> -----------------------------------------
>
>                 Key: YARN-9998
>                 URL: https://issues.apache.org/jira/browse/YARN-9998
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Szilard Nemeth
>            Priority: Minor
>
> Many things can be improved:
> * Field compactionTimer could be a local variable
> * Field versiondb should be camelcase
> * initDatabase is a very long method: Initialize db / versionDb should be in separate methods, split this method into smaller chunks
> * Remove TODOs
> * Remove duplicated code block in LeveldbConfigurationStore.CompactionTimerTask
> * Any other cleanup



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org