You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/19 12:42:01 UTC

[GitHub] [flink] zhuzhurk opened a new pull request, #20312: [FLINK-28612] [FLINK-28612][runtime] SpeculativeScheduler cancels pending slot allocation after canceling pending executions

zhuzhurk opened a new pull request, #20312:
URL: https://github.com/apache/flink/pull/20312

   ## What is the purpose of the change
   
   Canceling pending slot allocation before canceling executions will result in execution failures and pollute the logs. It will also result in an execution to be FAILED even if the execution vertex has FINISHED, which breaks the assumption of SpeculativeScheduler#isExecutionVertexPossibleToFinish().
   This PR changes SpeculativeScheduler to cancel pending slot allocation after canceling pending executions.
   
   ## Verifying this change
   
     - *Added units test in SpeculativeSchedulerTest*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #20312: [FLINK-28612] [FLINK-28612][runtime] SpeculativeScheduler cancels pending slot allocation after canceling pending executions

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20312:
URL: https://github.com/apache/flink/pull/20312#issuecomment-1189015896

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "072ca89d09842a4af54f6ad94c783f0f21fa433e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "072ca89d09842a4af54f6ad94c783f0f21fa433e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 072ca89d09842a4af54f6ad94c783f0f21fa433e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zhuzhurk commented on pull request #20312: [FLINK-28612] [FLINK-28612][runtime] SpeculativeScheduler cancels pending slot allocation after canceling pending executions

Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on PR #20312:
URL: https://github.com/apache/flink/pull/20312#issuecomment-1189979884

   Thanks for reviewing! @wanglijie95 
   Merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zhuzhurk closed pull request #20312: [FLINK-28612] [FLINK-28612][runtime] SpeculativeScheduler cancels pending slot allocation after canceling pending executions

Posted by GitBox <gi...@apache.org>.
zhuzhurk closed pull request #20312: [FLINK-28612] [FLINK-28612][runtime] SpeculativeScheduler cancels pending slot allocation after canceling pending executions
URL: https://github.com/apache/flink/pull/20312


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org