You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/08 21:32:51 UTC
[GitHub] [beam] lukecwik opened a new pull request, #22627: [WIP][BEAM-13015, #21250] Remove looking up thread local metrics container holder and object creation on hot path
lukecwik opened a new pull request, #22627:
URL: https://github.com/apache/beam/pull/22627
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] steveniemitz commented on pull request #22627: [BEAM-13015, #21250] Remove looking up thread local metrics container holder and object creation on hot path
Posted by GitBox <gi...@apache.org>.
steveniemitz commented on PR #22627:
URL: https://github.com/apache/beam/pull/22627#issuecomment-1216767236
> No, worries. Hopefully you had a good vacation.
I did, thank you!
this looks good to me, always great to get rid of static state as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #22627: [BEAM-13015, #21250] Remove looking up thread local metrics container holder and object creation on hot path
Posted by GitBox <gi...@apache.org>.
lukecwik commented on PR #22627:
URL: https://github.com/apache/beam/pull/22627#issuecomment-1215493637
No, worries. Hopefully you had a good vacation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] steveniemitz commented on pull request #22627: [BEAM-13015, #21250] Remove looking up thread local metrics container holder and object creation on hot path
Posted by GitBox <gi...@apache.org>.
steveniemitz commented on PR #22627:
URL: https://github.com/apache/beam/pull/22627#issuecomment-1214929242
sorry I was OOO last week, I'll take a look at this today!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22627: [BEAM-13015, #21250] Remove looking up thread local metrics container holder and object creation on hot path
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22627:
URL: https://github.com/apache/beam/pull/22627#issuecomment-1208844404
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #22627: [BEAM-13015, #21250] Remove looking up thread local metrics container holder and object creation on hot path
Posted by GitBox <gi...@apache.org>.
lukecwik commented on PR #22627:
URL: https://github.com/apache/beam/pull/22627#issuecomment-1208843844
R: @steveniemitz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik merged pull request #22627: [BEAM-13015, #21250] Remove looking up thread local metrics container holder and object creation on hot path
Posted by GitBox <gi...@apache.org>.
lukecwik merged PR #22627:
URL: https://github.com/apache/beam/pull/22627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org