You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2015/04/10 12:42:35 UTC
[Bug 57802] New: Compatibility with ICEfaces 1.8 over JSF 1.1 apps
https://bz.apache.org/bugzilla/show_bug.cgi?id=57802
Bug ID: 57802
Summary: Compatibility with ICEfaces 1.8 over JSF 1.1 apps
Product: Tomcat 8
Version: 8.0.21
Hardware: PC
Status: NEW
Severity: regression
Priority: P2
Component: EL
Assignee: dev@tomcat.apache.org
Reporter: wlpa2008@gmail.com
Created attachment 32642
--> https://bz.apache.org/bugzilla/attachment.cgi?id=32642&action=edit
The way I modified the EL support(but i suggested a solution in the bug
comment)
I noticed that some pages using boolean or String resulting EL expression which
used to function well under Tomcat 7 and earlier versions of Tomcat 8.
The source of this is the use of ELContext in some methods of
org.apache.el.lang.ELSupport. ELContext is used starting from JSF 1.2(unles I'm
wrong, then feel free to notice it to me). Trying to use it with JSF 1.1 app
results sometimes in null references giving NPE on the specified screens. To
correct it, i commented the relevant blocks of code. What I might suggest is,
for ascending compatibility, to use the following procedure:
-try to look for the value in ELContext
-if the result is null, then fallback to the older versions(e.g. Tomcat 7) ways
of resolving EL values
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57802] Compatibility with ICEfaces 1.8 over JSF 1.1 apps
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57802
--- Comment #12 from Mark Thomas <ma...@apache.org> ---
OK. No rush. We don't normally close things until there has been at least a
month of inactivity. Worst case if this gets closed before you have a test case
you can always re-open it when you have the test case.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57802] Compatibility with ICEfaces 1.8 over JSF 1.1 apps
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57802
Patrick WENDJI <wl...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |NEW
--- Comment #15 from Patrick WENDJI <wl...@gmail.com> ---
I provided a uptobox link instead
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57802] Compatibility with ICEfaces 1.8 over JSF 1.1 apps
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57802
--- Comment #11 from Patrick WENDJI <wl...@gmail.com> ---
Sorry for the silence. I'm a bit busy right now since I'm building the test
case part time. I'll come back to you once it's done.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57802] Compatibility with ICEfaces 1.8 over JSF 1.1 apps
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57802
--- Comment #17 from Patrick WENDJI <wl...@gmail.com> ---
Comment on attachment 32699
--> https://bz.apache.org/bugzilla/attachment.cgi?id=32699
ICEfaces 1.8.1 component showcase on Myfaces 1.1.5/Tomahawk 1.1.6
http://dl.free.fr/fKFKRAwpc
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57802] Compatibility with ICEfaces 1.8 over JSF 1.1 apps
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57802
--- Comment #16 from Mark Thomas <ma...@apache.org> ---
The download appears to require registration and/or payment.
I suggest you remove the JARs from WEB-INF/lib and replace them with a list of
files and versions (assuming we can grab them from Maven central). That should
bring the example under the BZ attachment limit. Alternatively, place the file
somewhere that doesn't require payment or registration.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57802] Compatibility with ICEfaces 1.8 over JSF 1.1 apps
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57802
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #18 from Mark Thomas <ma...@apache.org> ---
Thanks for the test case.
Your analysis was heading in the right direction but missed the real root
cause. The problem was the incorrect default implementation of
ELResolver.convertToType(). It failed to call
context.setPropertyResolved(false). This meant older ELResolver implementations
that inherited this method would return null and if
ELContext.getPropertyResolved() was true, that null was treated as a valid
conversion triggering the NPE.
This has been fixed in trunk and 8.0.x for 8.0.23 onwards.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57802] Compatibility with ICEfaces 1.8 over JSF 1.1 apps
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57802
Christopher Schultz <ch...@christopherschultz.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|INVALID |---
--- Comment #7 from Christopher Schultz <ch...@christopherschultz.net> ---
Can you please paste a *complete* code example, including any JSP headers and
JAR libraries that might be necessary to get that to compile and run?
Remember that not everybody is using your stack.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57802] Compatibility with ICEfaces 1.8 over JSF 1.1 apps
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57802
--- Comment #8 from Patrick WENDJI <wl...@gmail.com> ---
(In reply to Christopher Schultz from comment #7)
> Can you please paste a *complete* code example, including any JSP headers
> and JAR libraries that might be necessary to get that to compile and run?
>
> Remember that not everybody is using your stack.
Basically, I'm using JSP Xml syntax. My pages are using pure XML so basically
no headers. For the librairies, there are ICEfaces 1.8.1, MyFaces 1.1.5 API and
IMPL(and dependencies in apache commons), Spring 2.5.5, Hibernate 3.2.5, axis2
1.4.1, BIRT 3.2.7(embedded). The fact is the class and page are part of a very
big project. That's why i'm extracting the problematic part.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57802] Compatibility with ICEfaces 1.8 over JSF 1.1 apps
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57802
--- Comment #6 from Patrick WENDJI <wl...@gmail.com> ---
(In reply to Christopher Schultz from comment #5)
> Care to post a JSP code sample that should work but doesn't? That would be
> the best thing to provide in a bug report such as this.
<ice:panelBorder id="page" styleClass="pnlBrdrDemo"
style="width:100%" renderNorth="#{not
uihome.showTitle}"
renderSouth="#{false}" renderCenter="#{true}"
renderWest="#{false}" renderEast="#{false}">
uihome refers to a not null JSF managed bean. The expression "not
uihome.showTitle" gives a NPE.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57802] Compatibility with ICEfaces 1.8 over JSF 1.1 apps
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57802
--- Comment #3 from Patrick WENDJI <wl...@gmail.com> ---
That's why i posted that bug
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57802] Compatibility with ICEfaces 1.8 over JSF 1.1 apps
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57802
--- Comment #2 from Patrick WENDJI <wl...@gmail.com> ---
I'm already using that option
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57802] Compatibility with ICEfaces 1.8 over JSF 1.1 apps
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57802
--- Comment #5 from Christopher Schultz <ch...@christopherschultz.net> ---
Care to post a JSP code sample that should work but doesn't? That would be the
best thing to provide in a bug report such as this.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57802] Compatibility with ICEfaces 1.8 over JSF 1.1 apps
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57802
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
OS| |All
Resolution|--- |INVALID
Status|NEW |RESOLVED
--- Comment #1 from Mark Thomas <ma...@apache.org> ---
See the comment in the EL spec regarding backwards compatability.
Tomcaat has the org.apache.el.parser.COERCE_TO_ZERO configuration option (see
http://tomcat.apache.org/tomcat-8.0-doc/config/systemprops.html#Expression_Language).
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57802] Compatibility with ICEfaces 1.8 over JSF 1.1 apps
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57802
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |NEEDINFO
--- Comment #9 from Mark Thomas <ma...@apache.org> ---
There is insufficient information in this report for a Tomcat developer to
reproduce it. Please keep in mind that the Tomcat developers may have zero
knowledge of JSF.
As Chris previously requested, a complete example needs to be provided. Whether
this is a single JSP and a list of required libraries (my preference) or a
zipped Maven project is a secondary issue. The primary issue is that a test
case needs to be provide that will enable a Tomcat developer to build a web
application that demonstrates this bug.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57802] Compatibility with ICEfaces 1.8 over JSF 1.1 apps
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57802
--- Comment #13 from Patrick WENDJI <wl...@gmail.com> ---
I have a test case but it's a 16MB WAR file. Can I upload it?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57802] Compatibility with ICEfaces 1.8 over JSF 1.1 apps
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57802
--- Comment #19 from Patrick WENDJI <wl...@gmail.com> ---
(In reply to Mark Thomas from comment #18)
> Thanks for the test case.
>
> Your analysis was heading in the right direction but missed the real root
> cause. The problem was the incorrect default implementation of
> ELResolver.convertToType(). It failed to call
> context.setPropertyResolved(false). This meant older ELResolver
> implementations that inherited this method would return null and if
> ELContext.getPropertyResolved() was true, that null was treated as a valid
> conversion triggering the NPE.
>
> This has been fixed in trunk and 8.0.x for 8.0.23 onwards.
I hope I helped. When will Tomcat 8.0.23 be released?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57802] Compatibility with ICEfaces 1.8 over JSF 1.1 apps
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57802
--- Comment #4 from Patrick WENDJI <wl...@gmail.com> ---
Thé fact ils that i have NPE for even ont NULL expressions.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57802] Compatibility with ICEfaces 1.8 over JSF 1.1 apps
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57802
--- Comment #14 from Patrick WENDJI <wl...@gmail.com> ---
Created attachment 32699
--> https://bz.apache.org/bugzilla/attachment.cgi?id=32699&action=edit
ICEfaces 1.8.1 component showcase on Myfaces 1.1.5/Tomahawk 1.1.6
The attachment works on Tomcat version 6.0.43 and 7.0.57 but not on 8.0.21
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57802] Compatibility with ICEfaces 1.8 over JSF 1.1 apps
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57802
--- Comment #10 from Mark Thomas <ma...@apache.org> ---
Without a test case this is going to get resolved as INVALID.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org