Re: [PR] Support 'EXTRACT' as a scalar function [pinot]

["yashmayya (via GitHub)" <gi...@apache.org>]

yashmayya commented on PR #13463:
URL: https://github.com/apache/pinot/pull/13463#issuecomment-2184724437

   `CalciteSqlCompilerTest.testExtract` is failing with:
   
   ```
   Caught exception while invoking method: public static int org.apache.pinot.common.function.scalar.DateTimeFunctions.extract(java.lang.String,long) with arguments: [YEAR, 2017-06-15]
   ```
   
   However, the [test](https://github.com/apache/pinot/blob/8df722a22f089d088bfb03e2b8aa49549bc4c38c/pinot-common/src/test/java/org/apache/pinot/sql/parsers/CalciteSqlCompilerTest.java#L263-L293) itself seems a little odd because even before the changes from this PR, while the test passes (i.e., the query compiles to a v1 Pinot query), trying to run an actual query like `SELECT EXTRACT(YEAR FROM '2017-06-15') FROM table;` results in a similar type related error:
   
   ```
   Error Code: 200
   
   QueryExecutionError:
   java.lang.IllegalArgumentException: Invalid long value: 2017-06-15
   	at org.apache.pinot.common.request.context.LiteralContext.getLongValue(LiteralContext.java:258)
   	at org.apache.pinot.core.operator.transform.function.LiteralTransformFunction.getLongLiteral(LiteralTransformFunction.java:65)
   	at org.apache.pinot.core.operator.transform.function.LiteralTransformFunction.transformToLongValuesSV(LiteralTransformFunction.java:141)
   	at org.apache.pinot.core.operator.transform.function.ExtractTransformFunction.transformToIntValuesSV(ExtractTransformFunction.java:61)
   ```
   
   @Jackie-Jiang can the test be updated to use timestamps in the form of milliseconds since epoch or is there some other missing context here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org