You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2017/11/08 16:13:29 UTC
Review Request 63670: Add a test for storage durability
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63670/
-----------------------------------------------------------
Review request for Aurora and Jordan Ly.
Repository: aurora
Description
-------
Introduces a new test that validates the durability of the storage system as a whole. Since we cannot count on loading the mesos JNI lib, a `FakeLog` is introduced to represent the durable layer. Additionally, the high-level nature of this test should allow it to serve as a conformance test when new storage layer implementations are added.
I also removed the `Comparable` interface from `Log.Position`, as it was never used.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/log/Log.java dc77eb435e5f8fdce56727a2f679e8e1907e977c
src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java 21855e184fe20dc339713978b32344b6950701ec
src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 67a0d5a7da90dc01b7a962c2f21730b4be06895a
src/test/java/org/apache/aurora/scheduler/log/mesos/MesosLogTest.java f142f545799d64f9352b0ac6c51942eedf5e9ced
src/test/java/org/apache/aurora/scheduler/storage/log/DurableStorageTest.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/storage/log/FakeLog.java PRE-CREATION
Diff: https://reviews.apache.org/r/63670/diff/1/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 63670: Add a test for storage durability
Posted by Bill Farner <wf...@apache.org>.
> On Nov. 8, 2017, 9:56 a.m., Jordan Ly wrote:
> > src/test/java/org/apache/aurora/scheduler/storage/log/DurableStorageTest.java
> > Lines 59 (patched)
> > <https://reviews.apache.org/r/63670/diff/1/?file=1884838#file1884838line59>
> >
> > I might name this NonVolatileStorageTest for consistency, and since I believe you are essentially only testing this interface.
I agree, done.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63670/#review190462
-----------------------------------------------------------
On Nov. 8, 2017, 8:13 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63670/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2017, 8:13 a.m.)
>
>
> Review request for Aurora and Jordan Ly.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Introduces a new test that validates the durability of the storage system as a whole. Since we cannot count on loading the mesos JNI lib, a `FakeLog` is introduced to represent the durable layer. Additionally, the high-level nature of this test should allow it to serve as a conformance test when new storage layer implementations are added.
>
> I also removed the `Comparable` interface from `Log.Position`, as it was never used.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/log/Log.java dc77eb435e5f8fdce56727a2f679e8e1907e977c
> src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java 21855e184fe20dc339713978b32344b6950701ec
> src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 67a0d5a7da90dc01b7a962c2f21730b4be06895a
> src/test/java/org/apache/aurora/scheduler/log/mesos/MesosLogTest.java f142f545799d64f9352b0ac6c51942eedf5e9ced
> src/test/java/org/apache/aurora/scheduler/storage/log/DurableStorageTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/storage/log/FakeLog.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/63670/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 63670: Add a test for storage durability
Posted by Jordan Ly <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63670/#review190462
-----------------------------------------------------------
Ship it!
src/test/java/org/apache/aurora/scheduler/storage/log/DurableStorageTest.java
Lines 59 (patched)
<https://reviews.apache.org/r/63670/#comment267840>
I might name this NonVolatileStorageTest for consistency, and since I believe you are essentially only testing this interface.
- Jordan Ly
On Nov. 8, 2017, 4:13 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63670/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2017, 4:13 p.m.)
>
>
> Review request for Aurora and Jordan Ly.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Introduces a new test that validates the durability of the storage system as a whole. Since we cannot count on loading the mesos JNI lib, a `FakeLog` is introduced to represent the durable layer. Additionally, the high-level nature of this test should allow it to serve as a conformance test when new storage layer implementations are added.
>
> I also removed the `Comparable` interface from `Log.Position`, as it was never used.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/log/Log.java dc77eb435e5f8fdce56727a2f679e8e1907e977c
> src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java 21855e184fe20dc339713978b32344b6950701ec
> src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 67a0d5a7da90dc01b7a962c2f21730b4be06895a
> src/test/java/org/apache/aurora/scheduler/log/mesos/MesosLogTest.java f142f545799d64f9352b0ac6c51942eedf5e9ced
> src/test/java/org/apache/aurora/scheduler/storage/log/DurableStorageTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/storage/log/FakeLog.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/63670/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 63670: Add a test for storage durability
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63670/#review190608
-----------------------------------------------------------
Ship it!
Master (773d2d6) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 8, 2017, 8:13 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63670/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2017, 8:13 a.m.)
>
>
> Review request for Aurora and Jordan Ly.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Introduces a new test that validates the durability of the storage system as a whole. Since we cannot count on loading the mesos JNI lib, a `FakeLog` is introduced to represent the durable layer. Additionally, the high-level nature of this test should allow it to serve as a conformance test when new storage layer implementations are added.
>
> I also removed the `Comparable` interface from `Log.Position`, as it was never used.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/log/Log.java dc77eb435e5f8fdce56727a2f679e8e1907e977c
> src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java 21855e184fe20dc339713978b32344b6950701ec
> src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 67a0d5a7da90dc01b7a962c2f21730b4be06895a
> src/test/java/org/apache/aurora/scheduler/log/mesos/MesosLogTest.java f142f545799d64f9352b0ac6c51942eedf5e9ced
> src/test/java/org/apache/aurora/scheduler/storage/log/FakeLog.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/storage/log/NonVolatileStorageTest.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/63670/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 63670: Add a test for storage durability
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63670/#review190452
-----------------------------------------------------------
Ship it!
Master (5dfe51c) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 8, 2017, 4:13 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63670/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2017, 4:13 p.m.)
>
>
> Review request for Aurora and Jordan Ly.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Introduces a new test that validates the durability of the storage system as a whole. Since we cannot count on loading the mesos JNI lib, a `FakeLog` is introduced to represent the durable layer. Additionally, the high-level nature of this test should allow it to serve as a conformance test when new storage layer implementations are added.
>
> I also removed the `Comparable` interface from `Log.Position`, as it was never used.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/log/Log.java dc77eb435e5f8fdce56727a2f679e8e1907e977c
> src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java 21855e184fe20dc339713978b32344b6950701ec
> src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 67a0d5a7da90dc01b7a962c2f21730b4be06895a
> src/test/java/org/apache/aurora/scheduler/log/mesos/MesosLogTest.java f142f545799d64f9352b0ac6c51942eedf5e9ced
> src/test/java/org/apache/aurora/scheduler/storage/log/DurableStorageTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/storage/log/FakeLog.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/63670/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>