Re: [PATCH] Proposed changes to clean up both System println and Booleancalls

[Antonio Gallardo <ag...@agsoftware.dnsalias.com>]

Robert S. Sfeir dijo:
> Per David's recommendation, and instructions on the site, I've uploaded
> the patches diff file to my site, since my client wraps (it raps y'all
> :-)  )
>
> Pathches can be gotten from:
>
> http://www.codepuccino.com/ojb-patches/patches-112203.txt

I would recommend to change:

logger.debug( sqle.getMessage() );

to:

logger.isDebugEnabled() {
   logger.debug( sqle.getMessage() );
}

That way we can improve the performance by first checking if the Debug is
Enable and is so, then execute the sqle.getMessage() method.

In the above example the sqle.getMessage() method is always executed.

The same apply for fatal(), info(), etc.

Best Regards,

Antonio Gallardo


---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org