You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "xavier-GitHub76 (via GitHub)" <gi...@apache.org> on 2024/05/16 10:51:40 UTC
[I] DISPLAY_MAX_ROW [superset]
xavier-GitHub76 opened a new issue, #28549:
URL: https://github.com/apache/superset/issues/28549
Hello,
when I run a request with lot of rows, I have an alert message.
The number od rows isn't correct.
10.000 is mentionned / 100.000
Best regards
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] DISPLAY_MAX_ROW 10.000 / 100.000 [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #28549:
URL: https://github.com/apache/superset/issues/28549#issuecomment-2115741216
Dosu is almost right. There is a `ROW_LIMIT` config, but that's for chart data.
The error you see right there in the UI, however IS correct.
`DISPLAY_MAX_ROW` in `config.py` is set by default to 10,000, and that's the limit you're hitting, just like it says. You can raise it in your config if you'd like.
Admittedly, it's not a great experience that the UI even _shows_ higher than you're allowed to request... maybe that Select menu should look up and respect the `DISPLAY_MAX_ROW` setting, and/or display it in a tooltip so the user is more aware of it. If you feel like opening a PR to make it better, that would be cool!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] DISPLAY_MAX_ROW 10.000 / 100.000 [superset]
Posted by "dosubot[bot] (via GitHub)" <gi...@apache.org>.
dosubot[bot] commented on issue #28549:
URL: https://github.com/apache/superset/issues/28549#issuecomment-2114886131
<!-- Greeting -->
Salut @xavier-GitHub76 ! Heureux de te retrouver par ici. 😄 Je vois que tu as rencontré un nouveau défi avec les limites des lignes. Pas de souci, je jette un œil à ton problème et je te reviens avec une réponse complète sous peu.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] DISPLAY_MAX_ROW 10.000 / 100.000 [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #28549: DISPLAY_MAX_ROW 10.000 / 100.000
URL: https://github.com/apache/superset/issues/28549
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] DISPLAY_MAX_ROW 10.000 / 100.000 [superset]
Posted by "xavier-GitHub76 (via GitHub)" <gi...@apache.org>.
xavier-GitHub76 commented on issue #28549:
URL: https://github.com/apache/superset/issues/28549#issuecomment-2222394962
Hello,
Thank you for the clarifications provided.
There are several ways to limit the number of rows (ROW_LIMIT, DISPLAY_MAX_ROW), the drop-down list could take the most restrictive of these variables as its maximum value.
Thus the user would make a choice that is always achievable.
This would also avoid having a surprising error message.
Currently the message tells the user to modify their query by adding a limit or a filter to display 100,000 values even though they will technically never be able to reach this number of rows.
Sincerely
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] DISPLAY_MAX_ROW 10.000 / 100.000 [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #28549:
URL: https://github.com/apache/superset/issues/28549#issuecomment-2224103623
If you want to propose a change, and/or open a PR to that effect, I think folks would be supportive!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org