[jtc] anybody build iis plugin lately

[kevin seguin <se...@motive.com>]

when i try to use jtc/jk/native/iis/isapi.ds[wp], i get errors that look
like this:

The file
g:\dev\jakarta\jakarta-tomcat-connectors\jk\native\iis\isapi.dsp has
been modified and cannot be loaded as a Developer Studio project.

ideas??

by the way, it'd be nice to have an nmake file here...  if someone could
generate one :)

thanks.

Re: [jtc] anybody build iis plugin lately

[Andy Armstrong <an...@tagish.com>]

kevin seguin wrote:
> 
> >
> > I've fixed isapi.dsp and added an nmake Makefile (isapi.mak). I also had
> > to fix a vouple of syntax errors in jk_isapi_plugin.c that I think were
> > changes that Henri made in an attempt to bring the IIS connector in line
> > with the latest jk code.
> >
> > One of the changes Henri had made was similar to a change he made in the
> > Domino connector. For now I've commented out the lines in question,
> > which I don't think will break anything, but to incorporate that change
> > fully in the Domino connector I had to make some non trivial changes to
> > the code to defer initialisation of the worker map until the first
> > request is seen by the connector. I think I'd have to do the same thing
> > with the IIS connector to make it work (basically the problem is that
> > Henri's code is looking for the name of the server which isn't available
> > either from IIS or from Domino until you're inside a real request).
> >
> > I can go ahead and make the necessary changes, but I'm concious that I
> > might be stepping on someone else's toes given that I'm not really the
> > maintainer of the IIS connector. Should I go ahead and do it?
> >
> 
> i haven't seen much movement in the iis connector for a while, and i
> have no idea whose baby it is :)  i'd say go for it if you have some
> ideas to improve/fix it.
> people who are interested will see your changes and can view the diffs
> and if they have problems, they can speak up ;-)

Yup I think I'll give it a bash.

-- 
Andy Armstrong, Tagish

Re: [jtc] anybody build iis plugin lately

[kevin seguin <se...@motive.com>]

> 
> I've fixed isapi.dsp and added an nmake Makefile (isapi.mak). I also had
> to fix a vouple of syntax errors in jk_isapi_plugin.c that I think were
> changes that Henri made in an attempt to bring the IIS connector in line
> with the latest jk code.
> 
> One of the changes Henri had made was similar to a change he made in the
> Domino connector. For now I've commented out the lines in question,
> which I don't think will break anything, but to incorporate that change
> fully in the Domino connector I had to make some non trivial changes to
> the code to defer initialisation of the worker map until the first
> request is seen by the connector. I think I'd have to do the same thing
> with the IIS connector to make it work (basically the problem is that
> Henri's code is looking for the name of the server which isn't available
> either from IIS or from Domino until you're inside a real request).
> 
> I can go ahead and make the necessary changes, but I'm concious that I
> might be stepping on someone else's toes given that I'm not really the
> maintainer of the IIS connector. Should I go ahead and do it?
> 

i haven't seen much movement in the iis connector for a while, and i
have no idea whose baby it is :)  i'd say go for it if you have some
ideas to improve/fix it.  
people who are interested will see your changes and can view the diffs
and if they have problems, they can speak up ;-)

Re: [jtc] anybody build iis plugin lately

[Andy Armstrong <an...@tagish.com>]

I've fixed isapi.dsp and added an nmake Makefile (isapi.mak). I also had
to fix a vouple of syntax errors in jk_isapi_plugin.c that I think were
changes that Henri made in an attempt to bring the IIS connector in line
with the latest jk code.

One of the changes Henri had made was similar to a change he made in the
Domino connector. For now I've commented out the lines in question,
which I don't think will break anything, but to incorporate that change
fully in the Domino connector I had to make some non trivial changes to
the code to defer initialisation of the worker map until the first
request is seen by the connector. I think I'd have to do the same thing
with the IIS connector to make it work (basically the problem is that
Henri's code is looking for the name of the server which isn't available
either from IIS or from Domino until you're inside a real request).

I can go ahead and make the necessary changes, but I'm concious that I
might be stepping on someone else's toes given that I'm not really the
maintainer of the IIS connector. Should I go ahead and do it?

Andy Armstrong wrote:
> 
> kevin seguin wrote:
> 
> > > I can probably do that too unless anyone else is a more appropriate
> > > volunteer.
> > >
> >
> > i've also be tossing around the idea of a plain old gnu makefile too...
> > but i suppose an nmake file would be better for most people.  if the dsp
> > works for you, andy, you should be able to simply export isapi.mak and
> > check that in.
> 
> I haven't looked at it, but I'll have a go at it later tonight.
> 
> --
> Andy Armstrong, Tagish

-- 
Andy Armstrong, Tagish

Re: [jtc] anybody build iis plugin lately

[Andy Armstrong <an...@tagish.com>]

kevin seguin wrote:

> > I can probably do that too unless anyone else is a more appropriate
> > volunteer.
> >
> 
> i've also be tossing around the idea of a plain old gnu makefile too...
> but i suppose an nmake file would be better for most people.  if the dsp
> works for you, andy, you should be able to simply export isapi.mak and
> check that in.

I haven't looked at it, but I'll have a go at it later tonight.

-- 
Andy Armstrong, Tagish

Re: [jtc] anybody build iis plugin lately

[kevin seguin <se...@motive.com>]

> > when i try to use jtc/jk/native/iis/isapi.ds[wp], i get errors that look
> > like this:
> >
> > The file
> > g:\dev\jakarta\jakarta-tomcat-connectors\jk\native\iis\isapi.dsp has
> > been modified and cannot be loaded as a Developer Studio project.
> 
> I haven't noticed that with IIS, but I got the same thing when I hand
> edited the dsapi.dsp file for the Domino connector. It seems that,
> although Microsoft have implemented a textual file format for the Visual
> Studio project files if you actually edit them outside Visual Studio
> something breaks! This is presumably to protect us from ourselves.
> Please don't get me started...
> 
> I've just verified here that some types of edit are OK on dsp files so
> I'm not sure what triggers this message.
> 
> In the absence of anyone else volunteering I'd be happy to have a look
> at this -- I've got several IIS boxes (for my sins) on which I can test
> it.
> 
> > ideas??
> >
> > by the way, it'd be nice to have an nmake file here...  if someone could
> > generate one :)
> 
> I can probably do that too unless anyone else is a more appropriate
> volunteer.
> 

i've also be tossing around the idea of a plain old gnu makefile too... 
but i suppose an nmake file would be better for most people.  if the dsp
works for you, andy, you should be able to simply export isapi.mak and
check that in.

thanks :)

Re: [jtc] anybody build iis plugin lately

[Andy Armstrong <an...@tagish.com>]

kevin seguin wrote:
> 
> when i try to use jtc/jk/native/iis/isapi.ds[wp], i get errors that look
> like this:
> 
> The file
> g:\dev\jakarta\jakarta-tomcat-connectors\jk\native\iis\isapi.dsp has
> been modified and cannot be loaded as a Developer Studio project.

I haven't noticed that with IIS, but I got the same thing when I hand
edited the dsapi.dsp file for the Domino connector. It seems that,
although Microsoft have implemented a textual file format for the Visual
Studio project files if you actually edit them outside Visual Studio
something breaks! This is presumably to protect us from ourselves.
Please don't get me started...

I've just verified here that some types of edit are OK on dsp files so
I'm not sure what triggers this message.

In the absence of anyone else volunteering I'd be happy to have a look
at this -- I've got several IIS boxes (for my sins) on which I can test
it.

> ideas??
> 
> by the way, it'd be nice to have an nmake file here...  if someone could
> generate one :)

I can probably do that too unless anyone else is a more appropriate
volunteer.

-- 
Andy Armstrong, Tagish