You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/31 12:45:44 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #17935: Fix instantiating Vault Secret Backend during configuration

kaxil commented on a change in pull request #17935:
URL: https://github.com/apache/airflow/pull/17935#discussion_r699286648



##########
File path: airflow/providers/hashicorp/secrets/vault.py
##########
@@ -206,7 +205,12 @@ def get_conn_uri(self, conn_id: str) -> Optional[str]:
 
         return response.get("conn_uri") if response else None
 
-    def get_connection(self, conn_id: str) -> Optional[Connection]:
+    # Make sure connection is imported this way for type checking, otherwise when importing
+    # the backend it will get a circular dependency and fail
+    if TYPE_CHECKING:
+        from airflow.models.connection import Connection

Review comment:
       This can go at the top of the file




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org