You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/12/13 06:57:46 UTC

[GitHub] [dolphinscheduler] kezhenxu94 commented on pull request #13173: Format task parameter as pretty json

kezhenxu94 commented on PR #13173:
URL: https://github.com/apache/dolphinscheduler/pull/13173#issuecomment-1347828577

   > > I'm +0 to the changes, prettifying the JSON in logs is good for human beings, but it might break log collecting system like ELK, if users collect the logs to ELK stack, they have extra work to config the line breaks inside the JSON.
   > 
   > I got you, this is an disvantage. in fact, we didn't support using es to store task log :), 
   
   It doesn't need our support, ELK can be used to collect any kind of logs and we don't know whether users are using this or not. But as I said, I have no opinion on the changes, it was just a reminder, so feel free to merge this PR when it's ready


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org