You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ja...@apache.org on 2018/09/30 18:49:08 UTC
[cordova-paramedic] branch janpio-fix_jshint_errors created (now
f60c5d6)
This is an automated email from the ASF dual-hosted git repository.
janpio pushed a change to branch janpio-fix_jshint_errors
in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git.
at f60c5d6 fix confusing ! usage
This branch includes the following new commits:
new 857c3e9 add missing semicolons
new f60c5d6 fix confusing ! usage
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[cordova-paramedic] 02/02: fix confusing ! usage
Posted by ja...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
janpio pushed a commit to branch janpio-fix_jshint_errors
in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git
commit f60c5d612851aeec8e02f8b471893943f994a319
Author: Jan Piotrowski <pi...@gmail.com>
AuthorDate: Sun Sep 30 20:48:57 2018 +0200
fix confusing ! usage
---
lib/paramedic.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/paramedic.js b/lib/paramedic.js
index 7f518a1..4f09966 100644
--- a/lib/paramedic.js
+++ b/lib/paramedic.js
@@ -123,7 +123,7 @@ ParamedicRunner.prototype.checkConfig = function () {
throw new Error('No tests to run: both --skipAppiumTests and --skipMainTests are used');
}
checkCli: {
- if (!(this.config.getCli() === 'cordova') && !(this.config.getCli() === 'phonegap')) {
+ if (this.config.getCli() !== 'cordova' && this.config.getCli() !== 'phonegap') {
if (path.isAbsolute(this.config.getCli())) {
break checkCli;
}
@@ -329,7 +329,7 @@ ParamedicRunner.prototype.runLocalTests = function () {
self.setPermissions();
logger.normal('cordova-paramedic: running command ' + command);
- if (!self.config.getPlatformId() === util.BROWSER) {
+ if (self.config.getPlatformId() !== util.BROWSER) {
return execPromise(command);
}
runProcess = cp.exec(command, function () {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[cordova-paramedic] 01/02: add missing semicolons
Posted by ja...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
janpio pushed a commit to branch janpio-fix_jshint_errors
in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git
commit 857c3e964ba9a6dc0f32452c743f143e880f2a0b
Author: Jan Piotrowski <pi...@gmail.com>
AuthorDate: Sun Sep 30 20:48:42 2018 +0200
add missing semicolons
---
lib/ParamedicConfig.js | 14 +++++++-------
lib/appium/AppiumRunner.js | 2 +-
lib/paramedic.js | 4 ++--
3 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/lib/ParamedicConfig.js b/lib/ParamedicConfig.js
index cdb955a..ad8d627 100644
--- a/lib/ParamedicConfig.js
+++ b/lib/ParamedicConfig.js
@@ -137,7 +137,7 @@ ParamedicConfig.prototype.getArgs = function () {
ParamedicConfig.prototype.setArgs = function (args) {
this._config.args = args;
-}
+};
ParamedicConfig.prototype.getPlatformId = function () {
return this._config.platform.split('@')[0];
@@ -252,7 +252,7 @@ ParamedicConfig.prototype.setSkipAppiumTests = function (skipAppiumTests) {
ParamedicConfig.prototype.isBrowserify = function () {
return this.getArgs().indexOf(BROWSERIFY_ARG) >= 0;
-}
+};
ParamedicConfig.prototype.setBrowserify = function (browserify) {
if (browserify) {
@@ -260,7 +260,7 @@ ParamedicConfig.prototype.setBrowserify = function (browserify) {
} else {
this._config.args = this._config.args.replace(BROWSERIFY_ARG, '');
}
-}
+};
ParamedicConfig.prototype.getPorts = function () {
return {
@@ -307,21 +307,21 @@ ParamedicConfig.prototype.setTarget = function (target) {
ParamedicConfig.prototype.getFileTransferServer = function () {
return this._config.fileTransferServer;
-}
+};
ParamedicConfig.prototype.setFileTransferServer = function (server) {
this._config.fileTransferServer = server;
-}
+};
ParamedicConfig.prototype.getCli = function () {
if (this._config.cli) {
return this._config.cli;
}
return DEFAULT_CLI;
-}
+};
ParamedicConfig.prototype.setCli = function (cli) {
this._config.cli = cli;
-}
+};
module.exports = ParamedicConfig;
diff --git a/lib/appium/AppiumRunner.js b/lib/appium/AppiumRunner.js
index 4556a2a..e647ee7 100644
--- a/lib/appium/AppiumRunner.js
+++ b/lib/appium/AppiumRunner.js
@@ -82,7 +82,7 @@ function getPackagePath(options) {
if (fs.existsSync(p)) {
packagePath = p;
return;
- };
+ }
});
if (packagePath != null) {
return packagePath;
diff --git a/lib/paramedic.js b/lib/paramedic.js
index 2e6b801..7f518a1 100644
--- a/lib/paramedic.js
+++ b/lib/paramedic.js
@@ -664,7 +664,7 @@ ParamedicRunner.prototype.getPackageFolder = function () {
return foundDir;
}
throw new Error ('Couldn\'t locate a built app directory. Looked here: ' + packageDirs);
-}
+};
ParamedicRunner.prototype.getPackageFolders = function () {
var packageFolders;
@@ -886,7 +886,7 @@ ParamedicRunner.prototype.connectSauceConnect = function () {
}
return Q.Promise(function (resolve, reject) {
- logger.info('cordova-paramedic: Starting Sauce Connect...')
+ logger.info('cordova-paramedic: Starting Sauce Connect...');
sauceConnectLauncher({
username: self.config.getSauceUser(),
accessKey: self.config.getSauceKey(),
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org