You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by "Shengping (JIRA)" <ji...@apache.org> on 2017/09/16 11:28:00 UTC
[jira] [Commented] (KYLIN-2871) Ineffective null check in
SegmentRange
[ https://issues.apache.org/jira/browse/KYLIN-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168889#comment-16168889 ]
Shengping commented on KYLIN-2871:
----------------------------------
I want to fix this issue.
> Ineffective null check in SegmentRange
> --------------------------------------
>
> Key: KYLIN-2871
> URL: https://issues.apache.org/jira/browse/KYLIN-2871
> Project: Kylin
> Issue Type: Bug
> Reporter: Ted Yu
> Priority: Minor
>
> For Endpoint#getComparator() :
> {code}
> } else if (b.isMax) {
> return a.isMax ? 0 : -1;
> } else {
> if (a == null || b == null)
> throw new IllegalStateException();
> {code}
> The null check should be placed in the front.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)