You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Hong Tang (JIRA)" <ji...@apache.org> on 2009/07/08 12:30:14 UTC
[jira] Created: (HADOOP-6131) A sysproperty should not be set
unless the property is set on the ant command line in build.xml.
A sysproperty should not be set unless the property is set on the ant command line in build.xml.
------------------------------------------------------------------------------------------------
Key: HADOOP-6131
URL: https://issues.apache.org/jira/browse/HADOOP-6131
Project: Hadoop Common
Issue Type: Bug
Components: build
Affects Versions: 0.21.0
Reporter: Hong Tang
Priority: Trivial
Patch for HADOOP-3315 contains an improper usage of setting a sysproperty. What it does now:
{code}
<sysproperty key="io.compression.codec.lzo.class"
value="${io.compression.codec.lzo.class}"/>
{code}
What should be:
{code}
<syspropertyset dynamic="no">
<propertyref name="io.compression.codec.lzo.class"/>
</syspropertyset>
{code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6131) A sysproperty should not be set
unless the property is set on the ant command line in build.xml.
Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hong Tang updated HADOOP-6131:
------------------------------
Fix Version/s: 0.21.0
Status: Patch Available (was: Open)
Attached patch made the minor changes to build.xml. No test necessary.
> A sysproperty should not be set unless the property is set on the ant command line in build.xml.
> ------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6131
> URL: https://issues.apache.org/jira/browse/HADOOP-6131
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Hong Tang
> Assignee: Hong Tang
> Priority: Trivial
> Fix For: 0.21.0
>
> Attachments: hadoop-6131.patch
>
>
> Patch for HADOOP-3315 contains an improper usage of setting a sysproperty. What it does now:
> {code}
> <sysproperty key="io.compression.codec.lzo.class"
> value="${io.compression.codec.lzo.class}"/>
> {code}
> What should be:
> {code}
> <syspropertyset dynamic="no">
> <propertyref name="io.compression.codec.lzo.class"/>
> </syspropertyset>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6131) A sysproperty should not be set
unless the property is set on the ant command line in build.xml.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated HADOOP-6131:
----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. thanks hong.
> A sysproperty should not be set unless the property is set on the ant command line in build.xml.
> ------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6131
> URL: https://issues.apache.org/jira/browse/HADOOP-6131
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Hong Tang
> Assignee: Hong Tang
> Priority: Trivial
> Fix For: 0.21.0
>
> Attachments: hadoop-6131.patch
>
>
> Patch for HADOOP-3315 contains an improper usage of setting a sysproperty. What it does now:
> {code}
> <sysproperty key="io.compression.codec.lzo.class"
> value="${io.compression.codec.lzo.class}"/>
> {code}
> What should be:
> {code}
> <syspropertyset dynamic="no">
> <propertyref name="io.compression.codec.lzo.class"/>
> </syspropertyset>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6131) A sysproperty should not be set
unless the property is set on the ant command line in build.xml.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728883#action_12728883 ]
Mahadev konar commented on HADOOP-6131:
---------------------------------------
+1 to the patch. the -1 from tests is because hudson is running create-c++-configure which isnt a target in common.
{code} [exec] /home/hudson/tools/ant/latest/bin/ant -Dversion=791937_HADOOP-6131_PATCH-12412848 -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes -Dcompile.c++=yes -Dforrest.home=/home/nigel/tools/forrest/latest -Djava5.home=/home/hudson/tools/java/latest1.5 create-c++-configure test-core
{code}
> A sysproperty should not be set unless the property is set on the ant command line in build.xml.
> ------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6131
> URL: https://issues.apache.org/jira/browse/HADOOP-6131
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Hong Tang
> Assignee: Hong Tang
> Priority: Trivial
> Fix For: 0.21.0
>
> Attachments: hadoop-6131.patch
>
>
> Patch for HADOOP-3315 contains an improper usage of setting a sysproperty. What it does now:
> {code}
> <sysproperty key="io.compression.codec.lzo.class"
> value="${io.compression.codec.lzo.class}"/>
> {code}
> What should be:
> {code}
> <syspropertyset dynamic="no">
> <propertyref name="io.compression.codec.lzo.class"/>
> </syspropertyset>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6131) A sysproperty should not be set
unless the property is set on the ant command line in build.xml.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728884#action_12728884 ]
Mahadev konar commented on HADOOP-6131:
---------------------------------------
+1 for the patch I meant...
> A sysproperty should not be set unless the property is set on the ant command line in build.xml.
> ------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6131
> URL: https://issues.apache.org/jira/browse/HADOOP-6131
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Hong Tang
> Assignee: Hong Tang
> Priority: Trivial
> Fix For: 0.21.0
>
> Attachments: hadoop-6131.patch
>
>
> Patch for HADOOP-3315 contains an improper usage of setting a sysproperty. What it does now:
> {code}
> <sysproperty key="io.compression.codec.lzo.class"
> value="${io.compression.codec.lzo.class}"/>
> {code}
> What should be:
> {code}
> <syspropertyset dynamic="no">
> <propertyref name="io.compression.codec.lzo.class"/>
> </syspropertyset>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-6131) A sysproperty should not be set
unless the property is set on the ant command line in build.xml.
Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hong Tang reassigned HADOOP-6131:
---------------------------------
Assignee: Hong Tang
> A sysproperty should not be set unless the property is set on the ant command line in build.xml.
> ------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6131
> URL: https://issues.apache.org/jira/browse/HADOOP-6131
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Hong Tang
> Assignee: Hong Tang
> Priority: Trivial
>
> Patch for HADOOP-3315 contains an improper usage of setting a sysproperty. What it does now:
> {code}
> <sysproperty key="io.compression.codec.lzo.class"
> value="${io.compression.codec.lzo.class}"/>
> {code}
> What should be:
> {code}
> <syspropertyset dynamic="no">
> <propertyref name="io.compression.codec.lzo.class"/>
> </syspropertyset>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6131) A sysproperty should not be set
unless the property is set on the ant command line in build.xml.
Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hong Tang updated HADOOP-6131:
------------------------------
Attachment: hadoop-6131.patch
> A sysproperty should not be set unless the property is set on the ant command line in build.xml.
> ------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6131
> URL: https://issues.apache.org/jira/browse/HADOOP-6131
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Hong Tang
> Assignee: Hong Tang
> Priority: Trivial
> Fix For: 0.21.0
>
> Attachments: hadoop-6131.patch
>
>
> Patch for HADOOP-3315 contains an improper usage of setting a sysproperty. What it does now:
> {code}
> <sysproperty key="io.compression.codec.lzo.class"
> value="${io.compression.codec.lzo.class}"/>
> {code}
> What should be:
> {code}
> <syspropertyset dynamic="no">
> <propertyref name="io.compression.codec.lzo.class"/>
> </syspropertyset>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6131) A sysproperty should not be set
unless the property is set on the ant command line in build.xml.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729186#action_12729186 ]
Hudson commented on HADOOP-6131:
--------------------------------
Integrated in Hadoop-Common-trunk #21 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/21/])
. A sysproperty should not be set unless the property is set on the ant command line in build.xml (hong tang via mahadev)
> A sysproperty should not be set unless the property is set on the ant command line in build.xml.
> ------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6131
> URL: https://issues.apache.org/jira/browse/HADOOP-6131
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Hong Tang
> Assignee: Hong Tang
> Priority: Trivial
> Fix For: 0.21.0
>
> Attachments: hadoop-6131.patch
>
>
> Patch for HADOOP-3315 contains an improper usage of setting a sysproperty. What it does now:
> {code}
> <sysproperty key="io.compression.codec.lzo.class"
> value="${io.compression.codec.lzo.class}"/>
> {code}
> What should be:
> {code}
> <syspropertyset dynamic="no">
> <propertyref name="io.compression.codec.lzo.class"/>
> </syspropertyset>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6131) A sysproperty should not be set
unless the property is set on the ant command line in build.xml.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728680#action_12728680 ]
Hadoop QA commented on HADOOP-6131:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12412848/hadoop-6131.patch
against trunk revision 791937.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/557/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/557/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/557/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/557/console
This message is automatically generated.
> A sysproperty should not be set unless the property is set on the ant command line in build.xml.
> ------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6131
> URL: https://issues.apache.org/jira/browse/HADOOP-6131
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Hong Tang
> Assignee: Hong Tang
> Priority: Trivial
> Fix For: 0.21.0
>
> Attachments: hadoop-6131.patch
>
>
> Patch for HADOOP-3315 contains an improper usage of setting a sysproperty. What it does now:
> {code}
> <sysproperty key="io.compression.codec.lzo.class"
> value="${io.compression.codec.lzo.class}"/>
> {code}
> What should be:
> {code}
> <syspropertyset dynamic="no">
> <propertyref name="io.compression.codec.lzo.class"/>
> </syspropertyset>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.