You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@subversion.apache.org by Kenneth Porter <sh...@sewingwitch.com> on 2004/10/26 01:29:21 UTC

Patches in Red Hat SRPM

I'm building the latest Rawhide SRPM:

<http://download.fedora.redhat.com/pub/fedora/linux/core/development/SRPMS/subversion-1.1.0-5.src.rpm>

I note that it includes 4 patches. Are any of these appropriate to include 
in the upstream sources? Here's the patch comments:

Patch .swig:
Remove code to pick up LDFLAGS for swig; breaks for lib64.

Patch .deplibs:
APR and APR-util are patched to store dependencies in the .la file.

Patch .rpath:
Only pass -rpath $(libdir) on the link line when linking libraries,
not programs.

Patch .pie:
Build subversion executables as PIEs. Requires a slight jig to
ensure that executables in the test suite are *not* build using
-pie, since that doesn't work when main() is not itself an
object built with -pie.


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Re: Patches in Red Hat SRPM

Posted by Max Bowsher <ma...@ukf.net>.
Kenneth Porter wrote:
> I'm building the latest Rawhide SRPM:
>
> <http://download.fedora.redhat.com/pub/fedora/linux/core/development/SRPMS/subversion-1.1.0-5.src.rpm>
>
> I note that it includes 4 patches. Are any of these appropriate to include
> in the upstream sources? Here's the patch comments:
>
> Patch .swig:
> Remove code to pick up LDFLAGS for swig; breaks for lib64.
>
> Patch .deplibs:
> APR and APR-util are patched to store dependencies in the .la file.
>
> Patch .rpath:
> Only pass -rpath $(libdir) on the link line when linking libraries,
> not programs.
>
> Patch .pie:
> Build subversion executables as PIEs. Requires a slight jig to
> ensure that executables in the test suite are *not* build using
> -pie, since that doesn't work when main() is not itself an
> object built with -pie.

mirrorservice.org allows you to peek inside archive files (including rpms)
it mirrors, and download individual files from inside the rpm - for example,
download just the patches, rather then the entire SRPM:

<http://www.mirrorservice.org/sites/download.fedora.redhat.com/pub/fedora/linux/core/development/SRPMS/subversion-1.1.0-5.src.rpm%5Bpeek%5D>


The "swig" and "rpath" patches are probably suitable to be included 
upstream. "deplibs" appears to be in response to Fedora-local patching of 
apr. Some of the infrastructure in "pie" might be absorbable, to make the 
"pie" patch smaller.

Max.


Max.


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org