You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/11/03 14:05:43 UTC
[GitHub] [accumulo] milleruntime commented on a change in pull request #1761: Refactor TabletGroupWatcher
milleruntime commented on a change in pull request #1761:
URL: https://github.com/apache/accumulo/pull/1761#discussion_r516030267
##########
File path: server/manager/src/main/java/org/apache/accumulo/master/Master.java
##########
@@ -1675,9 +1675,8 @@ public boolean delegationTokensAvailable() {
}
}
- public void markDeadServerLogsAsClosed(Map<TServerInstance,List<Path>> logsForDeadServers)
- throws WalMarkerException {
- WalStateManager mgr = new WalStateManager(getContext());
+ public void markDeadServerLogsAsClosed(WalStateManager mgr,
Review comment:
`TabletGroupWatcher` was the only thing using this method so I moved it from Master and made it private static.
##########
File path: server/manager/src/main/java/org/apache/accumulo/master/Master.java
##########
@@ -1675,9 +1675,8 @@ public boolean delegationTokensAvailable() {
}
}
- public void markDeadServerLogsAsClosed(Map<TServerInstance,List<Path>> logsForDeadServers)
- throws WalMarkerException {
- WalStateManager mgr = new WalStateManager(getContext());
+ public void markDeadServerLogsAsClosed(WalStateManager mgr,
Review comment:
In 73558943033d1a0e0167424e9f06cf834cfb0f39
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org