You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "rajagopr (via GitHub)" <gi...@apache.org> on 2023/04/04 21:13:25 UTC
[GitHub] [pinot] rajagopr opened a new pull request, #10542: Exposed the CSV header map as part of CSVRecordReader
rajagopr opened a new pull request, #10542:
URL: https://github.com/apache/pinot/pull/10542
Exposed a convenience method to retrieve the header row from the csv file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] snleee commented on a diff in pull request #10542: Exposed the CSV header map as part of CSVRecordReader
Posted by "snleee (via GitHub)" <gi...@apache.org>.
snleee commented on code in PR #10542:
URL: https://github.com/apache/pinot/pull/10542#discussion_r1157872025
##########
pinot-plugins/pinot-input-format/pinot-csv/src/main/java/org/apache/pinot/plugin/inputformat/csv/CSVRecordReader.java:
##########
@@ -150,6 +151,10 @@ private void init()
_iterator = _parser.iterator();
}
+ public Map<String, Integer> getCSVHeaderMap() {
Review Comment:
Can you add the javadoc comment on what's the key and what's the value for the header map?
##########
pinot-plugins/pinot-input-format/pinot-csv/src/main/java/org/apache/pinot/plugin/inputformat/csv/CSVRecordReader.java:
##########
@@ -150,6 +151,10 @@ private void init()
_iterator = _parser.iterator();
}
+ public Map<String, Integer> getCSVHeaderMap() {
+ return _parser.getHeaderMap();
Review Comment:
what happens to the record reader / headermap
if there's no header present? we can cover this in the comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] snleee merged pull request #10542: Exposed the CSV header map as part of CSVRecordReader
Posted by "snleee (via GitHub)" <gi...@apache.org>.
snleee merged PR #10542:
URL: https://github.com/apache/pinot/pull/10542
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] rajagopr commented on a diff in pull request #10542: Exposed the CSV header map as part of CSVRecordReader
Posted by "rajagopr (via GitHub)" <gi...@apache.org>.
rajagopr commented on code in PR #10542:
URL: https://github.com/apache/pinot/pull/10542#discussion_r1157903712
##########
pinot-plugins/pinot-input-format/pinot-csv/src/main/java/org/apache/pinot/plugin/inputformat/csv/CSVRecordReader.java:
##########
@@ -150,6 +151,10 @@ private void init()
_iterator = _parser.iterator();
}
+ public Map<String, Integer> getCSVHeaderMap() {
+ return _parser.getHeaderMap();
Review Comment:
added comments
##########
pinot-plugins/pinot-input-format/pinot-csv/src/main/java/org/apache/pinot/plugin/inputformat/csv/CSVRecordReader.java:
##########
@@ -150,6 +151,10 @@ private void init()
_iterator = _parser.iterator();
}
+ public Map<String, Integer> getCSVHeaderMap() {
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10542: Exposed the CSV header map as part of CSVRecordReader
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10542:
URL: https://github.com/apache/pinot/pull/10542#issuecomment-1496660022
## [Codecov](https://codecov.io/gh/apache/pinot/pull/10542?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10542](https://codecov.io/gh/apache/pinot/pull/10542?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ad50c4e) into [master](https://codecov.io/gh/apache/pinot/commit/145a8c00a19cfc8aed3521cbd4765b679f620f02?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (145a8c0) will **decrease** coverage by `6.06%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #10542 +/- ##
============================================
- Coverage 70.35% 64.29% -6.06%
+ Complexity 6463 6441 -22
============================================
Files 2103 2049 -54
Lines 112759 110277 -2482
Branches 16977 16682 -295
============================================
- Hits 79327 70902 -8425
- Misses 27880 34236 +6356
+ Partials 5552 5139 -413
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `?` | |
| unittests1 | `67.87% <ø> (+0.01%)` | :arrow_up: |
| unittests2 | `13.86% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 445 files with indirect coverage changes](https://codecov.io/gh/apache/pinot/pull/10542/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org