You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2014/10/15 02:44:50 UTC

Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26721/
-----------------------------------------------------------

Review request for hive, Ashutosh Chauhan and John Pullokkaran.


Repository: hive-git


Description
-------

see jira


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/reloperators/HiveProjectRel.java 7b434ea 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/ASTConverter.java f5a704f 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java 4f96d02 
  ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java 9c55379 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java e1eca13 
  ql/src/test/queries/clientpositive/select_same_col.q PRE-CREATION 
  ql/src/test/results/clientpositive/select_same_col.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/26721/diff/


Testing
-------


Thanks,

Sergey Shelukhin

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26721/#review57654
-----------------------------------------------------------



ql/src/test/results/clientpositive/tez/cbo_correctness.q.out
<https://reviews.apache.org/r/26721/#comment98463>

    not intended


- Sergey Shelukhin


On Oct. 21, 2014, 8:44 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26721/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 8:44 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/ASTConverter.java f5a704f 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java 4f96d02 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java 10ac4b2 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1b7a41d 
>   ql/src/test/queries/clientpositive/select_same_col.q PRE-CREATION 
>   ql/src/test/results/clientpositive/select_same_col.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26721/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

Posted by John Pullokkaran <jp...@hortonworks.com>.

> On Oct. 24, 2014, 8:12 p.m., John Pullokkaran wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java, line 346
> > <https://reviews.apache.org/r/26721/diff/4/?file=729400#file729400line346>
> >
> >     Can't we use Integer instead of this class?
> 
> Sergey Shelukhin wrote:
>     integer cannot be used as a assignable pass-by-pointer argument, Java doesn't have such concept

Never Mind (Integer is immutable)


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26721/#review58343
-----------------------------------------------------------


On Oct. 22, 2014, 11:18 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26721/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2014, 11:18 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/ASTConverter.java 0428263 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java 4f96d02 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java 10ac4b2 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java d8c50e3 
>   ql/src/test/queries/clientpositive/cbo_correctness.q 4d8f156 
>   ql/src/test/queries/clientpositive/select_same_col.q PRE-CREATION 
>   ql/src/test/results/clientpositive/cbo_correctness.q.out 7c25e1f 
>   ql/src/test/results/clientpositive/select_same_col.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/tez/cbo_correctness.q.out e467773 
> 
> Diff: https://reviews.apache.org/r/26721/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

Posted by Sergey Shelukhin <se...@hortonworks.com>.

> On Oct. 24, 2014, 8:12 p.m., John Pullokkaran wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java, line 346
> > <https://reviews.apache.org/r/26721/diff/4/?file=729400#file729400line346>
> >
> >     Can't we use Integer instead of this class?

integer cannot be used as a assignable pass-by-pointer argument, Java doesn't have such concept


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26721/#review58343
-----------------------------------------------------------


On Oct. 22, 2014, 11:18 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26721/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2014, 11:18 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/ASTConverter.java 0428263 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java 4f96d02 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java 10ac4b2 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java d8c50e3 
>   ql/src/test/queries/clientpositive/cbo_correctness.q 4d8f156 
>   ql/src/test/queries/clientpositive/select_same_col.q PRE-CREATION 
>   ql/src/test/results/clientpositive/cbo_correctness.q.out 7c25e1f 
>   ql/src/test/results/clientpositive/select_same_col.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/tez/cbo_correctness.q.out e467773 
> 
> Diff: https://reviews.apache.org/r/26721/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

Posted by John Pullokkaran <jp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26721/#review58343
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java
<https://reviews.apache.org/r/26721/#comment99298>

    Can't we use Integer instead of this class?


- John Pullokkaran


On Oct. 22, 2014, 11:18 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26721/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2014, 11:18 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/ASTConverter.java 0428263 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java 4f96d02 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java 10ac4b2 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java d8c50e3 
>   ql/src/test/queries/clientpositive/cbo_correctness.q 4d8f156 
>   ql/src/test/queries/clientpositive/select_same_col.q PRE-CREATION 
>   ql/src/test/results/clientpositive/cbo_correctness.q.out 7c25e1f 
>   ql/src/test/results/clientpositive/select_same_col.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/tez/cbo_correctness.q.out e467773 
> 
> Diff: https://reviews.apache.org/r/26721/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

Posted by John Pullokkaran <jp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26721/#review58369
-----------------------------------------------------------

Ship it!


Ship It!

- John Pullokkaran


On Oct. 22, 2014, 11:18 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26721/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2014, 11:18 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/ASTConverter.java 0428263 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java 4f96d02 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java 10ac4b2 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java d8c50e3 
>   ql/src/test/queries/clientpositive/cbo_correctness.q 4d8f156 
>   ql/src/test/queries/clientpositive/select_same_col.q PRE-CREATION 
>   ql/src/test/results/clientpositive/cbo_correctness.q.out 7c25e1f 
>   ql/src/test/results/clientpositive/select_same_col.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/tez/cbo_correctness.q.out e467773 
> 
> Diff: https://reviews.apache.org/r/26721/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

Posted by John Pullokkaran <jp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26721/#review58319
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/ASTConverter.java
<https://reviews.apache.org/r/26721/#comment99274>

    This is unused.


- John Pullokkaran


On Oct. 22, 2014, 11:18 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26721/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2014, 11:18 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/ASTConverter.java 0428263 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java 4f96d02 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java 10ac4b2 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java d8c50e3 
>   ql/src/test/queries/clientpositive/cbo_correctness.q 4d8f156 
>   ql/src/test/queries/clientpositive/select_same_col.q PRE-CREATION 
>   ql/src/test/results/clientpositive/cbo_correctness.q.out 7c25e1f 
>   ql/src/test/results/clientpositive/select_same_col.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/tez/cbo_correctness.q.out e467773 
> 
> Diff: https://reviews.apache.org/r/26721/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

Posted by Sergey Shelukhin <se...@hortonworks.com>.

> On Oct. 24, 2014, 8:11 p.m., John Pullokkaran wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java, line 409
> > <https://reviews.apache.org/r/26721/diff/4/?file=729400#file729400line409>
> >
> >     ColumnInfo uses internal name; and "internalName"can not be different from name in ColumnInfo.

this is internal name from old column info, not necessarily matching new column info as far as I can see


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26721/#review58342
-----------------------------------------------------------


On Oct. 22, 2014, 11:18 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26721/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2014, 11:18 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/ASTConverter.java 0428263 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java 4f96d02 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java 10ac4b2 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java d8c50e3 
>   ql/src/test/queries/clientpositive/cbo_correctness.q 4d8f156 
>   ql/src/test/queries/clientpositive/select_same_col.q PRE-CREATION 
>   ql/src/test/results/clientpositive/cbo_correctness.q.out 7c25e1f 
>   ql/src/test/results/clientpositive/select_same_col.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/tez/cbo_correctness.q.out e467773 
> 
> Diff: https://reviews.apache.org/r/26721/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

Posted by John Pullokkaran <jp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26721/#review58342
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java
<https://reviews.apache.org/r/26721/#comment99297>

    ColumnInfo uses internal name; and "internalName"can not be different from name in ColumnInfo.


- John Pullokkaran


On Oct. 22, 2014, 11:18 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26721/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2014, 11:18 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/ASTConverter.java 0428263 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java 4f96d02 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java 10ac4b2 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java d8c50e3 
>   ql/src/test/queries/clientpositive/cbo_correctness.q 4d8f156 
>   ql/src/test/queries/clientpositive/select_same_col.q PRE-CREATION 
>   ql/src/test/results/clientpositive/cbo_correctness.q.out 7c25e1f 
>   ql/src/test/results/clientpositive/select_same_col.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/tez/cbo_correctness.q.out e467773 
> 
> Diff: https://reviews.apache.org/r/26721/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

Posted by John Pullokkaran <jp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26721/#review58344
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
<https://reviews.apache.org/r/26721/#comment99299>

    Why #TODO in log message


- John Pullokkaran


On Oct. 22, 2014, 11:18 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26721/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2014, 11:18 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/ASTConverter.java 0428263 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java 4f96d02 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java 10ac4b2 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java d8c50e3 
>   ql/src/test/queries/clientpositive/cbo_correctness.q 4d8f156 
>   ql/src/test/queries/clientpositive/select_same_col.q PRE-CREATION 
>   ql/src/test/results/clientpositive/cbo_correctness.q.out 7c25e1f 
>   ql/src/test/results/clientpositive/select_same_col.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/tez/cbo_correctness.q.out e467773 
> 
> Diff: https://reviews.apache.org/r/26721/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26721/
-----------------------------------------------------------

(Updated Oct. 22, 2014, 11:18 p.m.)


Review request for hive, Ashutosh Chauhan and John Pullokkaran.


Repository: hive-git


Description
-------

see jira


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/ASTConverter.java 0428263 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java 4f96d02 
  ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java 10ac4b2 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java d8c50e3 
  ql/src/test/queries/clientpositive/cbo_correctness.q 4d8f156 
  ql/src/test/queries/clientpositive/select_same_col.q PRE-CREATION 
  ql/src/test/results/clientpositive/cbo_correctness.q.out 7c25e1f 
  ql/src/test/results/clientpositive/select_same_col.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/tez/cbo_correctness.q.out e467773 

Diff: https://reviews.apache.org/r/26721/diff/


Testing
-------


Thanks,

Sergey Shelukhin

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26721/
-----------------------------------------------------------

(Updated Oct. 21, 2014, 8:44 p.m.)


Review request for hive, Ashutosh Chauhan and John Pullokkaran.


Repository: hive-git


Description
-------

see jira


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/ASTConverter.java f5a704f 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java 4f96d02 
  ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java 10ac4b2 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1b7a41d 
  ql/src/test/queries/clientpositive/select_same_col.q PRE-CREATION 
  ql/src/test/results/clientpositive/select_same_col.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/26721/diff/


Testing
-------


Thanks,

Sergey Shelukhin

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26721/
-----------------------------------------------------------

(Updated Oct. 17, 2014, 11:10 p.m.)


Review request for hive, Ashutosh Chauhan and John Pullokkaran.


Repository: hive-git


Description
-------

see jira


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/ASTConverter.java f5a704f 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java 4f96d02 
  ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java 10ac4b2 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1b7a41d 
  ql/src/test/queries/clientpositive/select_same_col.q PRE-CREATION 
  ql/src/test/results/clientpositive/select_same_col.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/tez/cbo_correctness.q.out f2c61e6 

Diff: https://reviews.apache.org/r/26721/diff/


Testing
-------


Thanks,

Sergey Shelukhin

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

Posted by Sergey Shelukhin <se...@hortonworks.com>.

> On Oct. 15, 2014, 9:39 p.m., John Pullokkaran wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/reloperators/HiveProjectRel.java, line 71
> > <https://reviews.apache.org/r/26721/diff/1/?file=721199#file721199line71>
> >
> >     Why are we recomputing the digest here?

that updates toString; not needed except for debugging


> On Oct. 15, 2014, 9:39 p.m., John Pullokkaran wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java, line 151
> > <https://reviews.apache.org/r/26721/diff/1/?file=721201#file721201line151>
> >
> >     This change seems just inversion of logic.
> >     Does Hive Coding convention proposes this?

IMHO the code is easier to read this way, because it always stays linear so there's no need to refer back to what is nested in what


> On Oct. 15, 2014, 9:39 p.m., John Pullokkaran wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java, line 354
> > <https://reviews.apache.org/r/26721/diff/1/?file=721202#file721202line354>
> >
> >     Instead of introducing a new class why don't you return a Pair<Boolean, Integer>

Only one caller needs the int; Pair will make it more cumbersome for all other callers


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26721/#review56817
-----------------------------------------------------------


On Oct. 15, 2014, 12:44 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26721/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2014, 12:44 a.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/reloperators/HiveProjectRel.java 7b434ea 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/ASTConverter.java f5a704f 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java 4f96d02 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java 9c55379 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java e1eca13 
>   ql/src/test/queries/clientpositive/select_same_col.q PRE-CREATION 
>   ql/src/test/results/clientpositive/select_same_col.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26721/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

Posted by John Pullokkaran <jp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26721/#review56817
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/reloperators/HiveProjectRel.java
<https://reviews.apache.org/r/26721/#comment97245>

    Why are we recomputing the digest here?



ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java
<https://reviews.apache.org/r/26721/#comment97246>

    This change seems just inversion of logic.
    Does Hive Coding convention proposes this?



ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java
<https://reviews.apache.org/r/26721/#comment97247>

    Is this needed now, since we did the check before  'fixTopOBSchema'



ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java
<https://reviews.apache.org/r/26721/#comment97248>

    Why is this wrong?



ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java
<https://reviews.apache.org/r/26721/#comment97249>

    Instead of introducing a new class why don't you return a Pair<Boolean, Integer>


- John Pullokkaran


On Oct. 15, 2014, 12:44 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26721/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2014, 12:44 a.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/reloperators/HiveProjectRel.java 7b434ea 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/ASTConverter.java f5a704f 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java 4f96d02 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java 9c55379 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java e1eca13 
>   ql/src/test/queries/clientpositive/select_same_col.q PRE-CREATION 
>   ql/src/test/results/clientpositive/select_same_col.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26721/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>