You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "tmedicci (via GitHub)" <gi...@apache.org> on 2023/08/01 12:47:20 UTC
[GitHub] [nuttx] tmedicci opened a new pull request, #9993: Build system: Add PREBUILD definition
tmedicci opened a new pull request, #9993:
URL: https://github.com/apache/nuttx/pull/9993
## Summary
* Build system: Add PREBUILD definition
Add PREBUILD definition and `prebuild` recipe to call it before `pass1` and `pass2` recipes. This `prebuild` step enables running CPU/board-specific operations before building the firmware, like tweaking or overriding configs that need to be set after the board configuration.
## Impact
No impact on existing devices. The definition of PREBUILD is empty and needs to be provided by some CPU or board.
## Testing
Internal CI testing + NuttX CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] tmedicci commented on pull request #9993: Build system: Add PREBUILD definition
Posted by "tmedicci (via GitHub)" <gi...@apache.org>.
tmedicci commented on PR #9993:
URL: https://github.com/apache/nuttx/pull/9993#issuecomment-1661906137
> if you want to get pip bootstrap script under macosx instance just run `curl -O https://bootstrap.pypa.io/get-pip.py`
Thank you, but I'm not sure if your comment targeted the correct PR. I didn't change anything on MacOS (about the failing CI, I couldn't check the reason, but it seems it's failing on other PRs too). I don't think it's related to the PR itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] mu578 commented on pull request #9993: Build system: Add PREBUILD definition
Posted by "mu578 (via GitHub)" <gi...@apache.org>.
mu578 commented on PR #9993:
URL: https://github.com/apache/nuttx/pull/9993#issuecomment-1661296744
if you want to get pip bootstrap script under macosx instance just run `curl -O https://bootstrap.pypa.io/get-pip.py`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] tmedicci commented on a diff in pull request #9993: Build system: Add PREBUILD definition
Posted by "tmedicci (via GitHub)" <gi...@apache.org>.
tmedicci commented on code in PR #9993:
URL: https://github.com/apache/nuttx/pull/9993#discussion_r1281105000
##########
tools/Unix.mk:
##########
@@ -508,7 +518,7 @@ pass2: $(NUTTXLIBS)
# pass1 dependencies and pass1 first, then build pass2 dependencies and pass2.
# in that case, execute 'make pass1 pass2' from the command line.
-$(BIN): pass1 pass2
+$(BIN): prebuild pass1 pass2
Review Comment:
You're right. I totally forgot the parallel execution... let me think how I can handle that...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #9993: Build system: Add PREBUILD definition
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #9993:
URL: https://github.com/apache/nuttx/pull/9993
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9993: Build system: Add PREBUILD definition
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #9993:
URL: https://github.com/apache/nuttx/pull/9993#discussion_r1281046617
##########
tools/Unix.mk:
##########
@@ -508,7 +518,7 @@ pass2: $(NUTTXLIBS)
# pass1 dependencies and pass1 first, then build pass2 dependencies and pass2.
# in that case, execute 'make pass1 pass2' from the command line.
-$(BIN): pass1 pass2
+$(BIN): prebuild pass1 pass2
Review Comment:
but prebuild will run in parallel with pass1 and pass2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] tmedicci commented on a diff in pull request #9993: Build system: Add PREBUILD definition
Posted by "tmedicci (via GitHub)" <gi...@apache.org>.
tmedicci commented on code in PR #9993:
URL: https://github.com/apache/nuttx/pull/9993#discussion_r1281719090
##########
tools/Unix.mk:
##########
@@ -508,7 +518,7 @@ pass2: $(NUTTXLIBS)
# pass1 dependencies and pass1 first, then build pass2 dependencies and pass2.
# in that case, execute 'make pass1 pass2' from the command line.
-$(BIN): pass1 pass2
+$(BIN): prebuild pass1 pass2
Review Comment:
Updated the PR, @xiaoxiang781216. Now we shouldn't have any problems with parallel execution...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] tmedicci commented on pull request #9993: Build system: Add PREBUILD definition
Posted by "tmedicci (via GitHub)" <gi...@apache.org>.
tmedicci commented on PR #9993:
URL: https://github.com/apache/nuttx/pull/9993#issuecomment-1661964230
> @tmedicci know that we have CMake support, I think this same PREBUILD logic should be included there.
I agree that would be useful! I'll try to provide another PR as soon as I figure out about CMake on NuttX.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on pull request #9993: Build system: Add PREBUILD definition
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #9993:
URL: https://github.com/apache/nuttx/pull/9993#issuecomment-1661076001
@tmedicci know that we have CMake support, I think this same PREBUILD logic should be included there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org