You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@doris.apache.org by GitBox <gi...@apache.org> on 2019/08/14 12:15:44 UTC

[GitHub] [incubator-doris] morningman commented on a change in pull request #1642: add kafka_default_offsets when no partiotion specify .support read kafka partition from start

morningman commented on a change in pull request #1642: add kafka_default_offsets  when no partiotion specify .support read kafka partition from start
URL: https://github.com/apache/incubator-doris/pull/1642#discussion_r313836798
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/analysis/CreateRoutineLoadStmt.java
 ##########
 @@ -401,6 +407,11 @@ private void checkKafkaProperties() throws AnalysisException {
                 }
             }
         }
+        // check default offset
+        final String kafkaODefaultffsetsString = dataSourceProperties.get(KAFKA_DEFAULT_OFFSETS);
 
 Review comment:
   ```suggestion
           final String kafkaDefaultOffsetsString = dataSourceProperties.get(KAFKA_DEFAULT_OFFSETS);
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org