[samza] branch master updated: SAMZA-2552: Avoid logging false positive error message on each record. (#1387)

[sh...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

shanthoosh pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/samza.git


The following commit(s) were added to refs/heads/master by this push:
     new 4e2fa96  SAMZA-2552: Avoid logging false positive error message on each record. (#1387)
4e2fa96 is described below

commit 4e2fa96ef9eb14588aaebe8b4cc4837f39c8e20e
Author: Slim Bouguerra <b-...@users.noreply.github.com>
AuthorDate: Wed Jun 24 13:07:12 2020 -0700

    SAMZA-2552: Avoid logging false positive error message on each record. (#1387)
---
 .../main/java/org/apache/samza/sql/translator/FilterTranslator.java  | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/samza-sql/src/main/java/org/apache/samza/sql/translator/FilterTranslator.java b/samza-sql/src/main/java/org/apache/samza/sql/translator/FilterTranslator.java
index 6515dc2..604f061 100644
--- a/samza-sql/src/main/java/org/apache/samza/sql/translator/FilterTranslator.java
+++ b/samza-sql/src/main/java/org/apache/samza/sql/translator/FilterTranslator.java
@@ -104,6 +104,11 @@ class FilterTranslator {
         LOG.error(errMsg, e);
         throw new SamzaException(errMsg, e);
       }
+      if (result[0] == null) {
+        // Case filter is applied on a null value -> result is neither true or false.
+        // Samza Filter operator supports primitive return types only, return false as per current convention.
+        return false;
+      }
       if (result[0] instanceof Boolean) {
         boolean retVal = (Boolean) result[0];
         LOG.debug(